[LayoutNG] Construct ConstraintSpace form Physical

[LayoutNG] Construct ConstraintSpace form Physical

Have the NGConstraintSpace constructors take a NGPhysicalConstraintSpace
and make it mandatory. Also add accessors to NGConstraintSpace and allow
a new NGPhysicalConstraintSpace to be constructed from a NGPhysicalSize.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
NOTRY=true

Committed: https://crrev.com/eeb67bf7fa6ef96b9840540db0753ba5847fee94
Cr-Commit-Position: refs/heads/master@{#415161}

[eae, 2016-08-26 23:48:07]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 23:48:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:51:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ikilpatrick, 2016-08-29 16:32:37]

lgtm

[ikilpatrick, 2016-08-29 16:32:54]

The CQ bit was checked by ikilpatrick@chromium.org

[cbiesinger, 2016-08-29 16:37:42]

lgtm

https://codereview.chromium.org/2283233002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2283233002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:45:
NGPhysicalConstraintSpace* PhysicalSpace() const { return physical_space_; }
Personally I'd name this PhysicalConstraintSpace because on first reading I
expected this to return a size indicating the available space, but up to you

[commit-bot: I haz the power, 2016-08-29 16:45:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-30 00:34:56]

Sigh. Almost 8 hours in the CQ.

[eae, 2016-08-30 00:35:15]

The CQ bit was unchecked by eae@chromium.org

[eae, 2016-08-30 00:35:24]

Description was changed from

==========
[LayoutNG] Construct ConstraintSpace form Physical

Have the NGConstraintSpace constructors take a NGPhysicalConstraintSpace
and make it mandatory. Also add accessors to NGConstraintSpace and allow
a new NGPhysicalConstraintSpace to be constructed from a NGPhysicalSize.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
==========

to

==========
[LayoutNG] Construct ConstraintSpace form Physical

Have the NGConstraintSpace constructors take a NGPhysicalConstraintSpace
and make it mandatory. Also add accessors to NGConstraintSpace and allow
a new NGPhysicalConstraintSpace to be constructed from a NGPhysicalSize.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
NOTRY=true
==========

[eae, 2016-08-30 00:35:31]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-08-30 01:30:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:32:55]

Description was changed from

==========
[LayoutNG] Construct ConstraintSpace form Physical

Have the NGConstraintSpace constructors take a NGPhysicalConstraintSpace
and make it mandatory. Also add accessors to NGConstraintSpace and allow
a new NGPhysicalConstraintSpace to be constructed from a NGPhysicalSize.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
NOTRY=true
==========

to

==========
[LayoutNG] Construct ConstraintSpace form Physical

Have the NGConstraintSpace constructors take a NGPhysicalConstraintSpace
and make it mandatory. Also add accessors to NGConstraintSpace and allow
a new NGPhysicalConstraintSpace to be constructed from a NGPhysicalSize.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
NOTRY=true
==========

[commit-bot: I haz the power, 2016-08-30 05:32:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-30 05:35:44]

Description was changed from

==========
[LayoutNG] Construct ConstraintSpace form Physical

Have the NGConstraintSpace constructors take a NGPhysicalConstraintSpace
and make it mandatory. Also add accessors to NGConstraintSpace and allow
a new NGPhysicalConstraintSpace to be constructed from a NGPhysicalSize.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
NOTRY=true
==========

to

==========
[LayoutNG] Construct ConstraintSpace form Physical

Have the NGConstraintSpace constructors take a NGPhysicalConstraintSpace
and make it mandatory. Also add accessors to NGConstraintSpace and allow
a new NGPhysicalConstraintSpace to be constructed from a NGPhysicalSize.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
NOTRY=true

Committed: https://crrev.com/eeb67bf7fa6ef96b9840540db0753ba5847fee94
Cr-Commit-Position: refs/heads/master@{#415161}
==========

[commit-bot: I haz the power, 2016-08-30 05:35:45]

Patchset 1 (id:??) landed as
https://crrev.com/eeb67bf7fa6ef96b9840540db0753ba5847fee94
Cr-Commit-Position: refs/heads/master@{#415161}