[LayoutNG] Construct ConstraintSpace form Physical

third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_constraint_space.h"
 
 #include "core/layout/ng/ng_units.h"
 
 namespace blink {
 
+static inline NGLogicalSize LogicalSizeForWritingMode(
+    NGWritingMode writing_mode,
+    NGPhysicalConstraintSpace* physical_space) {
+  return writing_mode == HorizontalTopBottom
+             ? NGLogicalSize(physical_space->ContainerSize().width,
+                             physical_space->ContainerSize().height)
+             : NGLogicalSize(physical_space->ContainerSize().height,
+                             physical_space->ContainerSize().width);
+}
+
+// TODO: This should set the size of the NGPhysicalConstraintSpace. Or we could
+// remove it requiring that a NGConstraintSpace is created from a
+// NGPhysicalConstraintSpace.
 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
                                      NGLogicalSize container_size)
     : physical_space_(new NGPhysicalConstraintSpace()),
       writing_mode_(writing_mode) {
   SetContainerSize(container_size);
 }
 
+NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
+                                     NGPhysicalConstraintSpace* physical_space)
+    : physical_space_(physical_space), writing_mode_(writing_mode) {
+  SetContainerSize(LogicalSizeForWritingMode(writing_mode, physical_space));
+}
+
 NGConstraintSpace::NGConstraintSpace(const NGConstraintSpace& other,
                                      NGLogicalSize container_size)
-    : physical_space_(new NGPhysicalConstraintSpace(*other.physical_space_)),
+    : physical_space_(*other.physical_space_),
       writing_mode_(other.writing_mode_) {
   SetContainerSize(container_size);
 }
 
 NGLogicalSize NGConstraintSpace::ContainerSize() const {
-  return writing_mode_ == HorizontalTopBottom
-             ? NGLogicalSize(physical_space_->container_size_.width,
-                             physical_space_->container_size_.height)
-             : NGLogicalSize(physical_space_->container_size_.height,
-                             physical_space_->container_size_.width);
+  return LogicalSizeForWritingMode(WritingMode(), physical_space_);
 }
 
 bool NGConstraintSpace::InlineTriggersScrollbar() const {
   return writing_mode_ == HorizontalTopBottom
              ? physical_space_->width_direction_triggers_scrollbar_
              : physical_space_->height_direction_triggers_scrollbar_;
 }
 
 bool NGConstraintSpace::BlockTriggersScrollbar() const {
   return writing_mode_ == HorizontalTopBottom
@@ skipping 69 matching lines @@
     physical_space_->height_direction_fragmentation_type_ = type;
   } else {
     DCHECK_EQ(static_cast<NGFragmentationType>(
                   physical_space_->height_direction_fragmentation_type_),
               FragmentNone);
     physical_space_->width_direction_triggers_scrollbar_ = type;
   }
 }
 
 }  // namespace blink