Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2283203002: Make it obvious when perf tryjob builds fail. (Closed)

Created:
4 years, 3 months ago by RobertoCN
Modified:
4 years, 3 months ago
Reviewers:
prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make it obvious when perf tryjob builds fail. Change the step status to warning, and issue a halting step. BUG=641581 R=prasadv Committed: https://chromium.googlesource.com/chromium/tools/build/+/c68d6ae954062559802aa1a41b7a31a923f7e732

Patch Set 1 #

Patch Set 2 : Fixing long line. #

Patch Set 3 : Adding link to failed build. #

Patch Set 4 : Rebasing, adding url field to mock response, retraining. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -70 lines) Patch
M scripts/slave/recipe_modules/perf_try/build_state.py View 1 2 3 2 chunks +12 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
RobertoCN
4 years, 3 months ago (2016-08-26 22:48:00 UTC) #1
RobertoCN
Added link to failed build as requested, PTAL.
4 years, 3 months ago (2016-08-26 23:04:53 UTC) #2
prasadv
lgtm
4 years, 3 months ago (2016-08-29 18:06:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283203002/40001
4 years, 3 months ago (2016-08-29 18:07:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30f04d79162ce410)
4 years, 3 months ago (2016-08-29 18:13:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283203002/60001
4 years, 3 months ago (2016-08-29 22:00:18 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 22:05:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/c68d6ae954062559802a...

Powered by Google App Engine
This is Rietveld 408576698