Make it obvious when perf tryjob builds fail.

scripts/slave/recipe_modules/perf_try/build_state.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import uuid
 
 # This is a wrapper class of revision that stores its build path and
 # queries its status. Part of the code are adapted from the RevisionState
 # class from auto-bisect module
@@ skipping 37 matching lines @@
     return 'gs://%s/Linux Builder/full-build-linux' % self.bucket
 
   def _is_completed(self):
     result = self.api.m.buildbucket.get_build(
         self.build_id,
         step_test_data=lambda: self.api.m.json.test_api.output_stream(
             {'build': {'status': 'COMPLETED'}}
         ))
     return result.stdout['build']['status'] == 'COMPLETED'
 
-  def _is_build_archived(self): # pragma: no cover
+  def _is_build_successful(self): # pragma: no cover
     result = self.api.m.buildbucket.get_build(
         self.build_id,
         step_test_data=lambda: self.api.m.json.test_api.output_stream(
-            {'build': {'result': 'SUCCESS'}}
+            {'build': {'result': 'SUCCESS', 'url': 'buildbot.dummy.url/job/12'}}
         ))
-    return result.stdout['build']['result'] == 'SUCCESS'
+    return (result.stdout['build']['result'] == 'SUCCESS',
+            result.stdout['build']['url'])
 
   # Duplicate code from auto_bisect.bisector.get_builder_bot_for_this_platform
   def get_builder_bot_for_this_platform(self):  # pragma: no cover
     bot_name = self.api.m.properties.get('buildername', '')
     if 'win' in bot_name:
       if any(b in bot_name for b in ['x64', 'gpu']):
         return 'winx64_bisect_builder'
       return 'win_perf_bisect_builder'
 
     if 'android' in bot_name:
@@ skipping 39 matching lines @@
       'tags':{}
     }
     result = self.api.m.buildbucket.put(
       [build_details],
       self.api.m.service_account.get_json_path(SERVICE_ACCOUNT))
     self.build_id = result.stdout['results'][0]['build']['id']
 
   def wait_for(self): # pragma: no cover
     while True:
       if self._is_completed():
-        if self._is_build_archived():
+        succeeded, build_url = self._is_build_successful()
+        if succeeded:
             break
+        self.api.m.step.active_result.presentation.status = (
+            self.api.m.step.WARNING)
+        self.api.m.step.active_result.presentation.links['FAILED BUILD'] = (
+            build_url)
+        self.api.m.halt('Build %s patch failed' % (
+            'with' if self.with_patch else 'without'))
         raise self.api.m.step.StepFailure('Build %s fails' % self.build_id)
       else:
         self.api.m.python.inline(
             'sleeping',
             """
             import sys
             import time
             time.sleep(20*60)
             sys.exit(0)
             """)
@@ skipping 38 matching lines @@
               import sys
               shutil.move(sys.argv[1], sys.argv[2])
               """,
               args=[zip_dir, build_dir])
       else:
         self.api.m.chromium_tests.download_and_unzip_build(
             mastername, buildername, update_step, bot_db,
             build_archive_url=self.build_file_path,
             build_revision=self.commit_hash,
             override_bot_type='tester')