Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2283103003: Replace deprecated ScopedVector<T> in chromeos::NetworkSmsHandler (Closed)

Created:
4 years, 3 months ago by Ben Chan
Modified:
4 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated ScopedVector<T> in chromeos::NetworkSmsHandler This CL changes chromeos::NetworkSmsHandler to use vector<unique_ptr<T>> instead of the deprecated ScopedVector<T>. BUG=554289 R=stevenjb@chromium.org Committed: https://crrev.com/26ebef06fba06d2f118facbc7d5774c5dd8c5500 Cr-Commit-Position: refs/heads/master@{#415038}

Patch Set 1 #

Patch Set 2 : rebased to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M chromeos/network/network_sms_handler.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chromeos/network/network_sms_handler.cc View 4 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Ben Chan
4 years, 3 months ago (2016-08-27 07:58:06 UTC) #4
stevenjb
lgtm
4 years, 3 months ago (2016-08-29 15:40:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283103003/1
4 years, 3 months ago (2016-08-29 15:49:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/288223)
4 years, 3 months ago (2016-08-29 17:01:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283103003/1
4 years, 3 months ago (2016-08-29 18:26:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283103003/20001
4 years, 3 months ago (2016-08-29 21:21:25 UTC) #17
Ben Chan
Committed patchset #2 (id:20001) to pending queue manually as cc09ad64e43bd29167dd34eb796615b11902f530 (presubmit successful).
4 years, 3 months ago (2016-08-29 23:44:55 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 23:44:58 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26ebef06fba06d2f118facbc7d5774c5dd8c5500
Cr-Commit-Position: refs/heads/master@{#415038}

Powered by Google App Engine
This is Rietveld 408576698