Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 22831029: Fixing switch order (Closed)

Created:
7 years, 4 months ago by sugoi1
Modified:
7 years, 4 months ago
Reviewers:
gab, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adding header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M content/public/common/content_switches.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sugoi1
7 years, 4 months ago (2013-08-22 15:08:07 UTC) #1
Jói
LGTM On Thu, Aug 22, 2013 at 3:08 PM, <sugoi@chromium.org> wrote: > Reviewers: Jói, gab, ...
7 years, 4 months ago (2013-08-22 15:09:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sugoi@chromium.org/22831029/1
7 years, 4 months ago (2013-08-22 15:10:45 UTC) #3
gab
Please fix header file as well. Thanks, Gab
7 years, 4 months ago (2013-08-22 15:19:12 UTC) #4
sugoi1
On 2013/08/22 15:19:12, gab wrote: > Please fix header file as well. > > Thanks, ...
7 years, 4 months ago (2013-08-22 15:25:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sugoi@chromium.org/22831029/20001
7 years, 4 months ago (2013-08-22 15:28:20 UTC) #6
gab
lgtm, thanks
7 years, 4 months ago (2013-08-22 16:01:10 UTC) #7
Jói
LGTM
7 years, 4 months ago (2013-08-22 16:03:48 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 19:58:36 UTC) #9
Message was sent while issue was closed.
Change committed as 219084

Powered by Google App Engine
This is Rietveld 408576698