Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 22831019: Deprecate FileError in FileAPI (Closed)

Created:
7 years, 4 months ago by kinuko
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, jianli
Visibility:
Public.

Description

Deprecate FileError in FileAPI Apps should expect DOMError instead. This change breaks existing apps, so I kept FileError in this CL but made it inherit from DOMError and marked '.code' attribute deprecated. BUG=276861 TEST=fast/files/*,fast/filesystem/* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156562

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : Fixing more tests #

Patch Set 5 : win test expectation fix (temporary) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -275 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/files/file-reader-abort.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/files/file-reader-abort-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/files/read-file-async-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/files/resources/read-common.js View 5 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/files/workers/worker-read-blob-sync-expected.txt View 1 chunk +19 lines, -19 lines 0 comments Download
M LayoutTests/fast/files/workers/worker-read-file-async-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/files/workers/worker-read-file-sync-expected.txt View 1 chunk +24 lines, -24 lines 0 comments Download
M LayoutTests/fast/filesystem/cross-filesystem-op.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/file-after-reload-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/file-metadata-after-write.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/not-enough-arguments.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/op-copy-expected.txt View 2 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/filesystem/op-get-entry-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/filesystem/op-get-metadata-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/op-move-expected.txt View 2 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/filesystem/op-remove-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/filesystem/op-restricted-chars-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/filesystem/op-restricted-names-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/filesystem/op-restricted-unicode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/async-operations.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/directory-entry-to-uri.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/file-entry-to-uri.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/file-from-file-entry.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/file-writer-abort.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/filesystem/resources/op-copy.js View 9 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/filesystem/resources/op-get-entry.js View 5 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/filesystem/resources/op-get-metadata.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/op-move.js View 9 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/filesystem/resources/op-remove.js View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/filesystem/resources/op-restricted-chars.js View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/filesystem/resources/op-restricted-names.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/filesystem/resources/op-restricted-unicode.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/op-tests-helper.js View 13 chunks +35 lines, -35 lines 0 comments Download
M LayoutTests/fast/filesystem/resources/simple-persistent.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/simple-required-arguments-getdirectory.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/simple-required-arguments-getfile.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/simple-required-arguments-getmetadata.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/simple-required-arguments-remove.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/resources/simple-temporary.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/script-tests/filesystem-reference.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/script-tests/filesystem-unserializable.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/script-tests/flags-passing.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/script-tests/read-directory.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/filesystem/simple-readonly-file-object.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/filesystem/resolve-uri-expected.txt View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/filesystem/script-tests/resolve-uri.js View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/filesystem/workers/resolve-url-expected.txt View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/dom/DOMError.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/fileapi/FileError.h View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/fileapi/FileError.cpp View 2 1 chunk +74 lines, -42 lines 0 comments Download
M Source/core/fileapi/FileError.idl View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
kinuko
Hi, recently I was just pinged that we should use DOMError instead of FileError in ...
7 years, 4 months ago (2013-08-21 12:10:06 UTC) #1
kinuko
On 2013/08/21 12:10:06, kinuko wrote: > Hi, recently I was just pinged that we should ...
7 years, 4 months ago (2013-08-21 12:26:40 UTC) #2
Mike West
+arv. I have no idea. Erik? https://codereview.chromium.org/22831019/diff/5001/Source/core/page/UseCounter.cpp File Source/core/page/UseCounter.cpp (right): https://codereview.chromium.org/22831019/diff/5001/Source/core/page/UseCounter.cpp#newcode665 Source/core/page/UseCounter.cpp:665: return "FileError is ...
7 years, 4 months ago (2013-08-21 12:43:59 UTC) #3
arv (Not doing code reviews)
https://codereview.chromium.org/22831019/diff/5001/Source/core/fileapi/FileError.idl File Source/core/fileapi/FileError.idl (right): https://codereview.chromium.org/22831019/diff/5001/Source/core/fileapi/FileError.idl#newcode32 Source/core/fileapi/FileError.idl:32: ] interface FileError : DOMError { Maybe [NoInterfaceObject] as ...
7 years, 4 months ago (2013-08-21 14:15:21 UTC) #4
do-not-use
https://codereview.chromium.org/22831019/diff/5001/Source/core/fileapi/FileError.idl File Source/core/fileapi/FileError.idl (right): https://codereview.chromium.org/22831019/diff/5001/Source/core/fileapi/FileError.idl#newcode32 Source/core/fileapi/FileError.idl:32: ] interface FileError : DOMError { On 2013/08/21 14:15:22, ...
7 years, 4 months ago (2013-08-21 14:19:04 UTC) #5
arv (Not doing code reviews)
https://codereview.chromium.org/22831019/diff/5001/Source/core/fileapi/FileError.idl File Source/core/fileapi/FileError.idl (right): https://codereview.chromium.org/22831019/diff/5001/Source/core/fileapi/FileError.idl#newcode32 Source/core/fileapi/FileError.idl:32: ] interface FileError : DOMError { On 2013/08/21 14:19:05, ...
7 years, 4 months ago (2013-08-21 14:21:38 UTC) #6
do-not-use
On 2013/08/21 14:21:38, arv wrote: > https://codereview.chromium.org/22831019/diff/5001/Source/core/fileapi/FileError.idl > File Source/core/fileapi/FileError.idl (right): > > https://codereview.chromium.org/22831019/diff/5001/Source/core/fileapi/FileError.idl#newcode32 > ...
7 years, 4 months ago (2013-08-21 14:40:01 UTC) #7
kinuko
Thanks Erik, Christophe and Mike! I went on updating the patch. > Good idea, I ...
7 years, 4 months ago (2013-08-21 16:27:45 UTC) #8
do-not-use
On 2013/08/21 16:27:45, kinuko wrote: > Thanks Erik, Christophe and Mike! I went on updating ...
7 years, 4 months ago (2013-08-21 16:45:07 UTC) #9
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-21 16:50:19 UTC) #10
do-not-use
LGTM2
7 years, 4 months ago (2013-08-21 16:53:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/22831019/4001
7 years, 4 months ago (2013-08-22 02:49:21 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=3059
7 years, 4 months ago (2013-08-22 05:28:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/22831019/28001
7 years, 4 months ago (2013-08-22 14:14:47 UTC) #14
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 16:03:33 UTC) #15
Message was sent while issue was closed.
Change committed as 156562

Powered by Google App Engine
This is Rietveld 408576698