Move enum CompilationType from objects.h to include/v8.h,

Move enum CompilationType from objects.h to include/v8.h, 
so it is available for embedders (eg blink).

BUG=v8:2844

[johnjbarton, 2013-08-15 20:55:57]

Ready for review

[johnjbarton, 2013-08-15 20:56:53]

On 2013/08/15 20:55:57, johnjbarton wrote:
> Ready for review

BUG=
https://code.google.com/p/v8/issues/detail?id=2844

[Michael Starzinger, 2013-08-19 19:42:28]

Taking this one over from Michael Stanton, since he is on vacation.

https://codereview.chromium.org/22831010/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/22831010/diff/1/include/v8.h#newcode982
include/v8.h:982: enum CompilationType {
We try not to expose internal behavior (and constants) through the API,
especially when they are not use in the API at all.

IIUC, these constants will be used to compare against Script::compile_type, or
to me more precises against ScriptMirror.prototype.compilationType. This is only
available if debugger support is actually enabled, another reason not to put the
constant into the API.

Would it be possible to add a ScriptMirror.prototype.compiledThroughEval (or
similar name) predicate to do the job? This predicate could then rely on the
JavaScript constants that we have defined in macros.py for that purpose. Also
note that I am not particularly familiar with the debugger API, so take this
suggestion with a grain of salt.

[johnjbarton, 2013-08-19 20:40:31]

On 2013/08/19 19:42:28, Michael Starzinger wrote:
> Would it be possible to add a ScriptMirror.prototype.compiledThroughEval (or
> similar name) predicate to do the job? This predicate could then rely on the
> JavaScript constants that we have defined in macros.py for that purpose. Also
> note that I am not particularly familiar with the debugger API, so take this
> suggestion with a grain of salt.

Aha! Thanks for the hint!  Apparently v8/src/debug-debugger.js is included in
blink's Debug context along with WebKit/Source/bindings/v8/DebuggerScript.js.
And in debug-debugger.js there is Debug.ScriptCompilationType exactly what I
need.

[Michael Starzinger, 2013-08-19 21:00:37]

On 2013/08/19 20:40:31, johnjbarton wrote:
> On 2013/08/19 19:42:28, Michael Starzinger wrote:
> > Would it be possible to add a ScriptMirror.prototype.compiledThroughEval (or
> > similar name) predicate to do the job? This predicate could then rely on the
> > JavaScript constants that we have defined in macros.py for that purpose.
Also
> > note that I am not particularly familiar with the debugger API, so take this
> > suggestion with a grain of salt.
> 
> Aha! Thanks for the hint!  Apparently v8/src/debug-debugger.js is included in
> blink's Debug context along with WebKit/Source/bindings/v8/DebuggerScript.js.
> And in debug-debugger.js there is Debug.ScriptCompilationType exactly what I
> need.

Awesome! I wasn't aware of Debug.ScriptCompilationType either until now. Yes,
this sounds much cleaner. Happy I could help.