Move enum CompilationType from objects.h to include/v8.h,

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 960 matching lines @@
   Handle<Integer> resource_column_offset_;
   Handle<Boolean> resource_is_shared_cross_origin_;
 };
 
 
 /**
  * A compiled JavaScript script.
  */
 class V8_EXPORT Script {
  public:
+    // Script compilation types.
+    enum CompilationType {

[Michael Starzinger, 2013/08/19 19:42:28]

We try not to expose internal behavior (and constants) through the API,
especially when they are not use in the API at all.

IIUC, these constants will be used to compare against Script::compile_type, or
to me more precises against ScriptMirror.prototype.compilationType. This is only
available if debugger support is actually enabled, another reason not to put the
constant into the API.

Would it be possible to add a ScriptMirror.prototype.compiledThroughEval (or
similar name) predicate to do the job? This predicate could then rely on the
JavaScript constants that we have defined in macros.py for that purpose. Also
note that I am not particularly familiar with the debugger API, so take this
suggestion with a grain of salt.

+      COMPILATION_TYPE_HOST = 0,
+      COMPILATION_TYPE_EVAL = 1
+    };
+
   /**
    * Compiles the specified script (context-independent).
    *
    * \param source Script source code.
    * \param origin Script origin, owned by caller, no references are kept
    *   when New() returns
    * \param pre_data Pre-parsing data, as obtained by ScriptData::PreCompile()
    *   using pre_data speeds compilation if it's done multiple times.
    *   Owned by caller, no references are kept when New() returns.
    * \param script_data Arbitrary data associated with script. Using
@@ skipping 5595 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_