Issue 22831004: Collections returned by mirror API should be unmodifiable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22831004: Collections returned by mirror API should be unmodifiable. (Closed)

Created:
7 years, 4 months ago by ahe

Modified:
7 years, 4 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, zarah

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Collections returned by mirror API should be unmodifiable. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26012

Patch Set 1 : #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -44 lines)			Patch
	M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View		18 chunks	+137 lines, -44 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/22831004/diff/3001/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/22831004/diff/3001/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode1310 dart/sdk/lib/_internal/lib/js_mirrors.dart:1310: V putIfAbsent(K key, V ifAbsent()) { _throw(); } ...

7 years, 4 months ago (2013-08-12 17:07:01 UTC) #2

ahe

Thank you, Martin! https://codereview.chromium.org/22831004/diff/3001/dart/sdk/lib/_internal/lib/js_mirrors.dart File dart/sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/22831004/diff/3001/dart/sdk/lib/_internal/lib/js_mirrors.dart#newcode1310 dart/sdk/lib/_internal/lib/js_mirrors.dart:1310: V putIfAbsent(K key, V ifAbsent()) { ...

7 years, 4 months ago (2013-08-12 17:10:21 UTC) #3

ahe

7 years, 4 months ago (2013-08-12 17:13:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26012 (presubmit successful).

Expand Messages | Collapse Messages