Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp

Issue 2283053002: Fix BaseAudioContext::hasPendingActivity() to make it GCed correctly (Closed)
Patch Set: [DO NOT SUBMIT] Adding printf for verification Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
index 2e72ec0778d2f4d10bedb4b47c8f0f8f00d29de2..86e23d556af8e405a9a28298f34af8343dfbb367 100644
--- a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
@@ -175,6 +175,7 @@ void BaseAudioContext::initialize()
void BaseAudioContext::clear()
{
+ printf("BaseAudioContext::clear\n");
m_destinationNode.clear();
// The audio rendering thread is dead. Nobody will schedule AudioHandler
// deletion. Let's do it ourselves.
@@ -184,6 +185,7 @@ void BaseAudioContext::clear()
void BaseAudioContext::uninitialize()
{
+ printf("BaseAudioContext::uninitialize\n");
DCHECK(isMainThread());
if (!isDestinationInitialized())
@@ -208,11 +210,13 @@ void BaseAudioContext::uninitialize()
void BaseAudioContext::stop()
{
+ printf("BaseAudioContext::stop\n");
uninitialize();
}
bool BaseAudioContext::hasPendingActivity() const
{
+ printf("BaseAudioContext::hasPendingActivity\n");
// There's no pending activity if the audio context has been cleared.
return !m_isCleared;
Raymond Toy 2016/09/02 18:19:21 This is different from PS1, where you were returni
}
« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698