Fix BaseAudioContext::hasPendingActivity() to make it GCed correctly

third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 157 matching lines @@
     if (m_destinationNode) {
         m_destinationNode->handler().initialize();
         // The AudioParams in the listener need access to the destination node, so only create the
         // listener if the destination node exists.
         m_listener = AudioListener::create(*this);
     }
 }
 
 void BaseAudioContext::clear()
 {
+    printf("BaseAudioContext::clear\n");
     m_destinationNode.clear();
     // The audio rendering thread is dead.  Nobody will schedule AudioHandler
     // deletion.  Let's do it ourselves.
     deferredTaskHandler().clearHandlersToBeDeleted();
     m_isCleared = true;
 }
 
 void BaseAudioContext::uninitialize()
 {
+    printf("BaseAudioContext::uninitialize\n");
     DCHECK(isMainThread());
 
     if (!isDestinationInitialized())
         return;
 
     // This stops the audio thread and all audio rendering.
     if (m_destinationNode)
         m_destinationNode->handler().uninitialize();
 
     // Get rid of the sources which may still be playing.
     releaseActiveSourceNodes();
 
     // Reject any pending resolvers before we go away.
     rejectPendingResolvers();
     didClose();
 
     DCHECK(m_listener);
     m_listener->waitForHRTFDatabaseLoaderThreadCompletion();
 
     clear();
 }
 
 void BaseAudioContext::stop()
 {
+    printf("BaseAudioContext::stop\n");
     uninitialize();
 }
 
 bool BaseAudioContext::hasPendingActivity() const
 {
+    printf("BaseAudioContext::hasPendingActivity\n");
     // There's no pending activity if the audio context has been cleared.
     return !m_isCleared;

[Raymond Toy, 2016/09/02 18:19:21]

This is different from PS1, where you were returning whether the destination had
connections or not.  Could this explain the results of this test?

 }
 
 AudioDestinationNode* BaseAudioContext::destination() const
 {
     // Cannot be called from the audio thread because this method touches objects managed by Oilpan,
     // and the audio thread is not managed by Oilpan.
     DCHECK(!isAudioThread());
     return m_destinationNode;
 }
 
@@ skipping 603 matching lines @@
 
 SecurityOrigin* BaseAudioContext::getSecurityOrigin() const
 {
     if (getExecutionContext())
         return getExecutionContext()->getSecurityOrigin();
 
     return nullptr;
 }
 
 } // namespace blink