third_party/WebKit/Source/core/input/PointerEventManager.cpp - Issue 2283013002: Adding chrome flag to disable implicit capture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 2283013002: Adding chrome flag to disable implicit capture (Closed)

Patch Set: Addressing comments about comments :) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp

diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp

index 6635c14d1ec4f4bdaef2cef775c2d35c542c5fd3..6eced7f17500571408547a5e1b34d499bca80180 100644

--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp

+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp

@@ -495,7 +495,8 @@ WebInputEventResult PointerEventManager::sendTouchPointerEvent(

processCaptureAndPositionOfPointerEvent(pointerEvent, target);

// Setting the implicit capture for touch

- if (pointerEvent->type() == EventTypeNames::pointerdown)

+ if (!RuntimeEnabledFeatures::pointerEventV1SpecCapturingEnabled()

+ && pointerEvent->type() == EventTypeNames::pointerdown)

setPointerCapture(pointerEvent->pointerId(), target);

WebInputEventResult result = dispatchPointerEvent(