Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 2283013002: Adding chrome flag to disable implicit capture (Closed)
Patch Set: Addressing comments about comments :) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/input/PointerEventManager.h" 5 #include "core/input/PointerEventManager.h"
6 6
7 #include "core/dom/ElementTraversal.h" 7 #include "core/dom/ElementTraversal.h"
8 #include "core/dom/shadow/FlatTreeTraversal.h" 8 #include "core/dom/shadow/FlatTreeTraversal.h"
9 #include "core/events/MouseEvent.h" 9 #include "core/events/MouseEvent.h"
10 #include "core/frame/FrameView.h" 10 #include "core/frame/FrameView.h"
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 488
489 WebInputEventResult PointerEventManager::sendTouchPointerEvent( 489 WebInputEventResult PointerEventManager::sendTouchPointerEvent(
490 EventTarget* target, PointerEvent* pointerEvent) 490 EventTarget* target, PointerEvent* pointerEvent)
491 { 491 {
492 if (m_inCanceledStateForPointerTypeTouch) 492 if (m_inCanceledStateForPointerTypeTouch)
493 return WebInputEventResult::NotHandled; 493 return WebInputEventResult::NotHandled;
494 494
495 processCaptureAndPositionOfPointerEvent(pointerEvent, target); 495 processCaptureAndPositionOfPointerEvent(pointerEvent, target);
496 496
497 // Setting the implicit capture for touch 497 // Setting the implicit capture for touch
498 if (pointerEvent->type() == EventTypeNames::pointerdown) 498 if (!RuntimeEnabledFeatures::pointerEventV1SpecCapturingEnabled()
499 && pointerEvent->type() == EventTypeNames::pointerdown)
499 setPointerCapture(pointerEvent->pointerId(), target); 500 setPointerCapture(pointerEvent->pointerId(), target);
500 501
501 WebInputEventResult result = dispatchPointerEvent( 502 WebInputEventResult result = dispatchPointerEvent(
502 getEffectiveTargetForPointerEvent(target, pointerEvent->pointerId()), 503 getEffectiveTargetForPointerEvent(target, pointerEvent->pointerId()),
503 pointerEvent); 504 pointerEvent);
504 505
505 if (pointerEvent->type() == EventTypeNames::pointerup 506 if (pointerEvent->type() == EventTypeNames::pointerup
506 || pointerEvent->type() == EventTypeNames::pointercancel) { 507 || pointerEvent->type() == EventTypeNames::pointercancel) {
507 releasePointerCapture(pointerEvent->pointerId()); 508 releasePointerCapture(pointerEvent->pointerId());
508 509
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
810 { 811 {
811 visitor->trace(m_frame); 812 visitor->trace(m_frame);
812 visitor->trace(m_nodeUnderPointer); 813 visitor->trace(m_nodeUnderPointer);
813 visitor->trace(m_pointerCaptureTarget); 814 visitor->trace(m_pointerCaptureTarget);
814 visitor->trace(m_pendingPointerCaptureTarget); 815 visitor->trace(m_pendingPointerCaptureTarget);
815 visitor->trace(m_touchEventManager); 816 visitor->trace(m_touchEventManager);
816 } 817 }
817 818
818 819
819 } // namespace blink 820 } // namespace blink
OLDNEW
« no previous file with comments | « content/public/common/content_features.cc ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698