Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2283003003: Use stroked rrects for Android shadow sample (Closed)

Created:
4 years, 3 months ago by jvanverth1
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use stroked rrects for Android shadow sample Changes the Android shadow sample to use stroked roundrects when we can (mainly if stroked geometry area < fill geometry area). Also changes the setup for the overstroke geometry so that it computes the correct distance to the outer edge. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283003003 Committed: https://skia.googlesource.com/skia/+/a4f1af8f9778462184c2bef91de1b1827568c08b

Patch Set 1 #

Patch Set 2 : Use stroke-and-fill rather than just fill #

Patch Set 3 : Some cleanup #

Total comments: 4

Patch Set 4 : Address comments #

Patch Set 5 : Ubuntu error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -85 lines) Patch
M samplecode/SampleAndroidShadows.cpp View 1 2 3 4 4 chunks +60 lines, -40 lines 0 comments Download
M src/effects/SkGaussianEdgeShader.cpp View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 2 chunks +44 lines, -40 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
jvanverth1
4 years, 3 months ago (2016-08-26 18:48:21 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroidShadows.cpp File samplecode/SampleAndroidShadows.cpp (right): https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroidShadows.cpp#newcode182 samplecode/SampleAndroidShadows.cpp:182: unsigned char gray = (unsigned char)(ambientAlpha*umbraAlpha*255.999f); // Convert ...
4 years, 3 months ago (2016-08-29 13:09:33 UTC) #4
egdaniel
On 2016/08/29 13:09:33, robertphillips wrote: > lgtm > > https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroidShadows.cpp > File samplecode/SampleAndroidShadows.cpp (right): > ...
4 years, 3 months ago (2016-08-29 13:18:08 UTC) #5
egdaniel
On 2016/08/29 13:09:33, robertphillips wrote: > lgtm > > https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroidShadows.cpp > File samplecode/SampleAndroidShadows.cpp (right): > ...
4 years, 3 months ago (2016-08-29 13:18:09 UTC) #6
egdaniel
On 2016/08/29 13:09:33, robertphillips wrote: > lgtm > > https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroidShadows.cpp > File samplecode/SampleAndroidShadows.cpp (right): > ...
4 years, 3 months ago (2016-08-29 13:18:10 UTC) #7
egdaniel
On 2016/08/29 13:09:33, robertphillips wrote: > lgtm > > https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroidShadows.cpp > File samplecode/SampleAndroidShadows.cpp (right): > ...
4 years, 3 months ago (2016-08-29 13:18:10 UTC) #8
jvanverth1
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroidShadows.cpp File samplecode/SampleAndroidShadows.cpp (right): https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroidShadows.cpp#newcode182 samplecode/SampleAndroidShadows.cpp:182: unsigned char gray = (unsigned char)(ambientAlpha*umbraAlpha*255.999f); On 2016/08/29 13:09:32, ...
4 years, 3 months ago (2016-08-29 13:31:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283003003/60001
4 years, 3 months ago (2016-08-29 13:31:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/11118)
4 years, 3 months ago (2016-08-29 13:34:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283003003/80001
4 years, 3 months ago (2016-08-29 13:55:15 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 14:17:53 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/a4f1af8f9778462184c2bef91de1b1827568c08b

Powered by Google App Engine
This is Rietveld 408576698