Use stroked rrects for Android shadow sample

Use stroked rrects for Android shadow sample

Changes the Android shadow sample to use stroked roundrects when
we can (mainly if stroked geometry area < fill geometry area).

Also changes the setup for the overstroke geometry so that it computes
the correct distance to the outer edge.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283003003

Committed: https://skia.googlesource.com/skia/+/a4f1af8f9778462184c2bef91de1b1827568c08b

[jvanverth1, 2016-08-26 18:34:51]

Description was changed from

==========
Use stroked rrects for Android shadow sample

Changes the Android shadow sample to use stroked roundrects when
we can (mainly if stroked geometry area < fill geometry area).

Also changes the setup for the overstroke geometry so that it computes
the correct distance to the outer edge.
==========

to

==========
Use stroked rrects for Android shadow sample

Changes the Android shadow sample to use stroked roundrects when
we can (mainly if stroked geometry area < fill geometry area).

Also changes the setup for the overstroke geometry so that it computes
the correct distance to the outer edge.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283003003
==========

[jvanverth1, 2016-08-26 18:48:21]

jvanverth@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[robertphillips, 2016-08-29 13:09:33]

lgtm

https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
File samplecode/SampleAndroidShadows.cpp (right):

https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:182: unsigned char gray = (unsigned
char)(ambientAlpha*umbraAlpha*255.999f);
// Convert radius to 6.2 fixed point and place in the G component.

?

https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:315: // If the area of the stroked geometry
is larger than the fill geometry, or
add "6.2" before "fixed point" ?

[egdaniel, 2016-08-29 13:18:08]

On 2016/08/29 13:09:33, robertphillips wrote:
> lgtm
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> File samplecode/SampleAndroidShadows.cpp (right):
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> samplecode/SampleAndroidShadows.cpp:182: unsigned char gray = (unsigned
> char)(ambientAlpha*umbraAlpha*255.999f);
> // Convert radius to 6.2 fixed point and place in the G component.
> 
> ?
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> samplecode/SampleAndroidShadows.cpp:315: // If the area of the stroked
geometry
> is larger than the fill geometry, or
> add "6.2" before "fixed point" ?

also LGTM. Thought I had sent that out on friday...

[egdaniel, 2016-08-29 13:18:09]

On 2016/08/29 13:09:33, robertphillips wrote:
> lgtm
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> File samplecode/SampleAndroidShadows.cpp (right):
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> samplecode/SampleAndroidShadows.cpp:182: unsigned char gray = (unsigned
> char)(ambientAlpha*umbraAlpha*255.999f);
> // Convert radius to 6.2 fixed point and place in the G component.
> 
> ?
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> samplecode/SampleAndroidShadows.cpp:315: // If the area of the stroked
geometry
> is larger than the fill geometry, or
> add "6.2" before "fixed point" ?

also LGTM. Thought I had sent that out on friday...

[egdaniel, 2016-08-29 13:18:10]

On 2016/08/29 13:09:33, robertphillips wrote:
> lgtm
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> File samplecode/SampleAndroidShadows.cpp (right):
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> samplecode/SampleAndroidShadows.cpp:182: unsigned char gray = (unsigned
> char)(ambientAlpha*umbraAlpha*255.999f);
> // Convert radius to 6.2 fixed point and place in the G component.
> 
> ?
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> samplecode/SampleAndroidShadows.cpp:315: // If the area of the stroked
geometry
> is larger than the fill geometry, or
> add "6.2" before "fixed point" ?

also LGTM. Thought I had sent that out on friday...

[egdaniel, 2016-08-29 13:18:10]

On 2016/08/29 13:09:33, robertphillips wrote:
> lgtm
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> File samplecode/SampleAndroidShadows.cpp (right):
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> samplecode/SampleAndroidShadows.cpp:182: unsigned char gray = (unsigned
> char)(ambientAlpha*umbraAlpha*255.999f);
> // Convert radius to 6.2 fixed point and place in the G component.
> 
> ?
> 
>
https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
> samplecode/SampleAndroidShadows.cpp:315: // If the area of the stroked
geometry
> is larger than the fill geometry, or
> add "6.2" before "fixed point" ?

also LGTM. Thought I had sent that out on friday...

[jvanverth1, 2016-08-29 13:31:42]

https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
File samplecode/SampleAndroidShadows.cpp (right):

https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:182: unsigned char gray = (unsigned
char)(ambientAlpha*umbraAlpha*255.999f);
On 2016/08/29 13:09:32, robertphillips wrote:
> // Convert radius to 6.2 fixed point and place in the G component.
> 
> ?

Done.

https://codereview.chromium.org/2283003003/diff/40001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:315: // If the area of the stroked geometry
is larger than the fill geometry, or
On 2016/08/29 13:09:33, robertphillips wrote:
> add "6.2" before "fixed point" ?

Done.

[jvanverth1, 2016-08-29 13:31:49]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-08-29 13:31:49]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2283003003/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-08-29 13:31:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 13:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 13:34:03]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[jvanverth1, 2016-08-29 13:55:08]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-08-29 13:55:09]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2283003003/#ps80001
(title: "Ubuntu error")

[commit-bot: I haz the power, 2016-08-29 13:55:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 14:17:52]

Description was changed from

==========
Use stroked rrects for Android shadow sample

Changes the Android shadow sample to use stroked roundrects when
we can (mainly if stroked geometry area < fill geometry area).

Also changes the setup for the overstroke geometry so that it computes
the correct distance to the outer edge.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283003003
==========

to

==========
Use stroked rrects for Android shadow sample

Changes the Android shadow sample to use stroked roundrects when
we can (mainly if stroked geometry area < fill geometry area).

Also changes the setup for the overstroke geometry so that it computes
the correct distance to the outer edge.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283003003

Committed:
https://skia.googlesource.com/skia/+/a4f1af8f9778462184c2bef91de1b1827568c08b
==========

[commit-bot: I haz the power, 2016-08-29 14:17:53]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/a4f1af8f9778462184c2bef91de1b1827568c08b