Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2282913002: Delete all references to GIT_MODE=True from build (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -142 lines) Patch
M scripts/slave/recipe_modules/chromedriver/example.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromite/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/example.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/emulator/example.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/legion/example.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/pgo/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/recipe_tryjob/api.py View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/skia/api.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/syzygy/example.py View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/v8/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/android/builder.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/boringssl.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/boringssl_docs.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/catapult.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/catapult_cron.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromedriver.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py View 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_codesearch.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/client.drmemory.recipe_autogen.py View 15 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/client.dynamorio.recipe_autogen.py View 10 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/client.fletch.recipe_autogen.py View 32 chunks +32 lines, -32 lines 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py View 6 chunks +6 lines, -6 lines 0 comments Download
M scripts/slave/recipes/closure_compilation.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/crashpad/continuous.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/custom_tabs_client.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart2js.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart2js_nobuild.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart_cross_compiler.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart_cross_tester.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart_vm.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dartium_build.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/emulator.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/flutter/engine.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gyp.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/legion/legion.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/mojo.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl/sdk.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/nacl/sdk_build.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/nacl_ports.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ozone_ecs.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/perf/telemetry_harness_upload.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/ct_skps.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/swarming/staging.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/continuous.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/coverage.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/kasko_official.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/syzygy/smoke_test.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/auto_roll_deps.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/auto_roll_push.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/auto_roll_release_process.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/auto_roll_v8_deps.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/auto_roll_v8rel.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/auto_tag.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8/infra_end_to_end.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/wasm_llvm.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/auto_roll_webrtc_deps.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/ios.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/ios_api_framework.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
agable
4 years, 3 months ago (2016-08-26 17:13:34 UTC) #1
martiniss
lgtm
4 years, 3 months ago (2016-08-26 17:14:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282913002/1
4 years, 3 months ago (2016-08-26 17:19:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30e0ae85f85a9d10)
4 years, 3 months ago (2016-08-26 17:27:39 UTC) #6
tandrii(chromium)
VERY LGTM
4 years, 3 months ago (2016-08-26 17:37:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282913002/1
4 years, 3 months ago (2016-08-26 17:37:59 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:42:38 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/90d4177d32d5c0ee899f...

Powered by Google App Engine
This is Rietveld 408576698