scripts/slave/recipe_modules/skia/api.py - Issue 2282913002: Delete all references to GIT_MODE=True from build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/skia/api.py

Issue 2282913002: Delete all references to GIT_MODE=True from build (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/skia/api.py

diff --git a/scripts/slave/recipe_modules/skia/api.py b/scripts/slave/recipe_modules/skia/api.py

index 497aac1a7206edfda8df54bd0f793bc6d06d4ba7..32ee13b7780860b0d6b476f0c99e5467f9fc485c 100644

--- a/scripts/slave/recipe_modules/skia/api.py

+++ b/scripts/slave/recipe_modules/skia/api.py

@@ -296,7 +296,6 @@ class SkiaApi(recipe_api.RecipeApi):

def checkout_steps(self):

"""Run the steps to obtain a checkout of Skia."""

cfg_kwargs = {}

- cfg_kwargs['GIT_MODE'] = True

if not self.persistent_checkout:

# We should've obtained the Skia checkout through isolates, so we don't

# need to perform the checkout ourselves.