Remove calls to SequencedWorkerPool::GetSequenceTokenForCurrentThread().

Remove calls to SequencedWorkerPool::GetSequenceTokenForCurrentThread().

Remove calls to SequencedWorkerPool::GetSequenceTokenForCurrentThread()
outside of base/. This won't return a valid sequence token when called
from a task forwarded to the new base/task_scheduler.

BUG=622400
Committed: https://crrev.com/fc341fe14e833479aebe4f1395ebbaf1b62d2957
Cr-Commit-Position: refs/heads/master@{#414948}

[fdoray, 2016-08-26 14:00:21]

fdoray@chromium.org changed reviewers:
+ achuith@chromium.org

[fdoray, 2016-08-26 14:00:22]

PTAL

https://codereview.chromium.org/2282813002/diff/1/chromeos/accelerometer/acce...
File chromeos/accelerometer/accelerometer_reader.cc (right):

https://codereview.chromium.org/2282813002/diff/1/chromeos/accelerometer/acce...
chromeos/accelerometer/accelerometer_reader.cc:238:
DCHECK(base::SequencedTaskRunnerHandle::IsSet());
I assume that the goal of this is to make sure that this method runs inside a
sequenced task? SequencedTaskRunnerHandle::IsSet() will return true from both
SequencedWorkerPool and TaskScheduler sequenced tasks, while
SequencedWorkerPool::GetSequenceTokenForCurrentThread().IsValid() only works in 
SequencedWorkerPool.

Note that even if this method runs inside a task posted to
|sequenced_task_runner|, SequencedTaskRunnerHandle::Get() might not be equal to
|sequenced_task_runner| (SequencedTaskRunnerHandle::Get() could return a wrapper
around |sequenced_task_runner|).

[achuithb, 2016-08-27 23:20:13]

lgtm

[fdoray, 2016-08-27 23:20:38]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-08-27 23:20:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 23:56:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-27 23:57:50]

Description was changed from

==========
Remove calls to SequencedWorkerPool::GetSequenceTokenForCurrentThread().

Remove calls to SequencedWorkerPool::GetSequenceTokenForCurrentThread()
outside of base/. This won't return a valid sequence token when called
from a task forwarded to the new base/task_scheduler.

BUG=622400
==========

to

==========
Remove calls to SequencedWorkerPool::GetSequenceTokenForCurrentThread().

Remove calls to SequencedWorkerPool::GetSequenceTokenForCurrentThread()
outside of base/. This won't return a valid sequence token when called
from a task forwarded to the new base/task_scheduler.

BUG=622400

Committed: https://crrev.com/fc341fe14e833479aebe4f1395ebbaf1b62d2957
Cr-Commit-Position: refs/heads/master@{#414948}
==========

[commit-bot: I haz the power, 2016-08-27 23:57:51]

Patchset 1 (id:??) landed as
https://crrev.com/fc341fe14e833479aebe4f1395ebbaf1b62d2957
Cr-Commit-Position: refs/heads/master@{#414948}

[gab, 2016-08-31 19:23:17]

On 2016/08/26 14:00:22, fdoray wrote:
> PTAL
> 
>
https://codereview.chromium.org/2282813002/diff/1/chromeos/accelerometer/acce...
> File chromeos/accelerometer/accelerometer_reader.cc (right):
> 
>
https://codereview.chromium.org/2282813002/diff/1/chromeos/accelerometer/acce...
> chromeos/accelerometer/accelerometer_reader.cc:238:
> DCHECK(base::SequencedTaskRunnerHandle::IsSet());
> I assume that the goal of this is to make sure that this method runs inside a
> sequenced task? SequencedTaskRunnerHandle::IsSet() will return true from both
> SequencedWorkerPool and TaskScheduler sequenced tasks, while
> SequencedWorkerPool::GetSequenceTokenForCurrentThread().IsValid() only works
in 
> SequencedWorkerPool.
> 
> Note that even if this method runs inside a task posted to
> |sequenced_task_runner|, SequencedTaskRunnerHandle::Get() might not be equal
to
> |sequenced_task_runner| (SequencedTaskRunnerHandle::Get() could return a
wrapper
> around |sequenced_task_runner|).

Should the API be made clearer? Want to make sure this doesn't become a common
mistake.