Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: chromeos/accelerometer/accelerometer_reader.cc

Issue 2282813002: Remove calls to SequencedWorkerPool::GetSequenceTokenForCurrentThread(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/accelerometer/accelerometer_reader.h" 5 #include "chromeos/accelerometer/accelerometer_reader.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/bind.h" 13 #include "base/bind.h"
14 #include "base/files/file_enumerator.h" 14 #include "base/files/file_enumerator.h"
15 #include "base/files/file_util.h" 15 #include "base/files/file_util.h"
16 #include "base/location.h" 16 #include "base/location.h"
17 #include "base/macros.h" 17 #include "base/macros.h"
18 #include "base/memory/singleton.h" 18 #include "base/memory/singleton.h"
19 #include "base/single_thread_task_runner.h" 19 #include "base/single_thread_task_runner.h"
20 #include "base/strings/string_number_conversions.h" 20 #include "base/strings/string_number_conversions.h"
21 #include "base/strings/string_util.h" 21 #include "base/strings/string_util.h"
22 #include "base/strings/stringprintf.h" 22 #include "base/strings/stringprintf.h"
23 #include "base/sys_info.h" 23 #include "base/sys_info.h"
24 #include "base/task_runner.h" 24 #include "base/task_runner.h"
25 #include "base/task_runner_util.h" 25 #include "base/task_runner_util.h"
26 #include "base/threading/platform_thread.h" 26 #include "base/threading/platform_thread.h"
27 #include "base/threading/sequenced_worker_pool.h" 27 #include "base/threading/sequenced_task_runner_handle.h"
28 #include "base/threading/thread_task_runner_handle.h" 28 #include "base/threading/thread_task_runner_handle.h"
29 29
30 namespace chromeos { 30 namespace chromeos {
31 31
32 namespace { 32 namespace {
33 33
34 // Paths to access necessary data from the accelerometer device. 34 // Paths to access necessary data from the accelerometer device.
35 const base::FilePath::CharType kAccelerometerDevicePath[] = 35 const base::FilePath::CharType kAccelerometerDevicePath[] =
36 FILE_PATH_LITERAL("/dev/cros-ec-accel"); 36 FILE_PATH_LITERAL("/dev/cros-ec-accel");
37 const base::FilePath::CharType kAccelerometerIioBasePath[] = 37 const base::FilePath::CharType kAccelerometerIioBasePath[] =
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 }; 228 };
229 229
230 AccelerometerFileReader::AccelerometerFileReader() 230 AccelerometerFileReader::AccelerometerFileReader()
231 : initialization_successful_(false), 231 : initialization_successful_(false),
232 observers_( 232 observers_(
233 new base::ObserverListThreadSafe<AccelerometerReader::Observer>()) { 233 new base::ObserverListThreadSafe<AccelerometerReader::Observer>()) {
234 } 234 }
235 235
236 void AccelerometerFileReader::Initialize( 236 void AccelerometerFileReader::Initialize(
237 scoped_refptr<base::SequencedTaskRunner> sequenced_task_runner) { 237 scoped_refptr<base::SequencedTaskRunner> sequenced_task_runner) {
238 DCHECK( 238 DCHECK(base::SequencedTaskRunnerHandle::IsSet());
fdoray 2016/08/26 14:00:22 I assume that the goal of this is to make sure tha
239 base::SequencedWorkerPool::GetSequenceTokenForCurrentThread().IsValid());
240 task_runner_ = sequenced_task_runner; 239 task_runner_ = sequenced_task_runner;
241 240
242 // Check for accelerometer symlink which will be created by the udev rules 241 // Check for accelerometer symlink which will be created by the udev rules
243 // file on detecting the device. 242 // file on detecting the device.
244 if (base::IsDirectoryEmpty(base::FilePath(kAccelerometerDevicePath))) { 243 if (base::IsDirectoryEmpty(base::FilePath(kAccelerometerDevicePath))) {
245 if (base::SysInfo::IsRunningOnChromeOS()) { 244 if (base::SysInfo::IsRunningOnChromeOS()) {
246 LOG(WARNING) << "Accelerometer device directory is empty at " 245 LOG(WARNING) << "Accelerometer device directory is empty at "
247 << kAccelerometerDevicePath; 246 << kAccelerometerDevicePath;
248 } 247 }
249 return; 248 return;
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 return; 327 return;
329 } 328 }
330 } 329 }
331 } 330 }
332 331
333 initialization_successful_ = true; 332 initialization_successful_ = true;
334 Read(); 333 Read();
335 } 334 }
336 335
337 void AccelerometerFileReader::Read() { 336 void AccelerometerFileReader::Read() {
338 DCHECK( 337 DCHECK(base::SequencedTaskRunnerHandle::IsSet());
339 base::SequencedWorkerPool::GetSequenceTokenForCurrentThread().IsValid());
340 ReadFileAndNotify(); 338 ReadFileAndNotify();
341 task_runner_->PostNonNestableDelayedTask( 339 task_runner_->PostNonNestableDelayedTask(
342 FROM_HERE, base::Bind(&AccelerometerFileReader::Read, this), 340 FROM_HERE, base::Bind(&AccelerometerFileReader::Read, this),
343 base::TimeDelta::FromMilliseconds( 341 base::TimeDelta::FromMilliseconds(
344 AccelerometerReader::kDelayBetweenReadsMs)); 342 AccelerometerReader::kDelayBetweenReadsMs));
345 } 343 }
346 344
347 void AccelerometerFileReader::AddObserver( 345 void AccelerometerFileReader::AddObserver(
348 AccelerometerReader::Observer* observer) { 346 AccelerometerReader::Observer* observer) {
349 observers_->AddObserver(observer); 347 observers_->AddObserver(observer);
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 } 535 }
538 536
539 AccelerometerReader::AccelerometerReader() 537 AccelerometerReader::AccelerometerReader()
540 : accelerometer_file_reader_(new AccelerometerFileReader()) { 538 : accelerometer_file_reader_(new AccelerometerFileReader()) {
541 } 539 }
542 540
543 AccelerometerReader::~AccelerometerReader() { 541 AccelerometerReader::~AccelerometerReader() {
544 } 542 }
545 543
546 } // namespace chromeos 544 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698