Issue 22827002: Change the allocation of the stdout and stderr collected by Process.runSync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22827002: Change the allocation of the stdout and stderr collected by Process.runSync (Closed)

Created:
7 years, 4 months ago by Søren Gjesse

Modified:
7 years, 4 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change the allocation of the stdout and stderr collected by Process.runSync Keep track of a list of buffers holding the output. When the process is done the parts of the output is collected into one Uint8List. On Windows I had to rename IOBuffer in the Windows eventhandler code. R=whesse@google.com BUG=

Patch Set 1 #

Patch Set 2 : Minor fixes #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+327 lines, -204 lines)			Patch
M	runtime/bin/eventhandler_win.h	View		8 chunks	+21 lines, -20 lines	0 comments	Download
M	runtime/bin/eventhandler_win.cc	View		27 chunks	+53 lines, -49 lines	0 comments	Download
M	runtime/bin/io_buffer.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/bin/io_buffer.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	runtime/bin/process.h	View	1	3 chunks	+106 lines, -18 lines	0 comments	Download
M	runtime/bin/process.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/process_linux.cc	View		6 chunks	+37 lines, -27 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View		6 chunks	+35 lines, -27 lines	0 comments	Download
M	runtime/bin/process_win.cc	View	1	6 chunks	+71 lines, -42 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

This change is based on https://codereview.chromium.org/21816002/, which is currently not committed.

7 years, 4 months ago (2013-08-12 12:30:48 UTC) #1

Søren Gjesse

7 years, 4 months ago (2013-08-12 14:50:55 UTC) #2

Closing this as it is now part of https://codereview.chromium.org/21816002/.

Expand Messages | Collapse Messages