Chromium Code Reviews
Description[compiler] Avoid Gcc compilation fail by including src/objects-inl.h in src/compiler.h.
The CL #38926 (https://codereview.chromium.org/2281543002) removed #include "src/objects-inl.h" from src/compiler.h.
This caused the Gcc compilation fail at the following code in src/objects.h, line 5329.
The error message was:
In file included from .././src/compilation-dependencies.h:9:0,
from .././src/compiler.h:12,
from ../src/compiler/pipeline-statistics.cc:7:
.././src/objects.h:5329:23: error: inline function ‘static v8::internal::Code::Flags v8::internal::Code::ComputeFlags(v8::internal::Code::Kind, v8::internal::ExtraICState, v8::internal::CacheHolderFlag)’ used but never defined [-Werror]
static inline Flags ComputeFlags(
^
cc1plus: all warnings being treated as errors
The definition of ComputeFlags is in src/objects-inl.h.
This CL fixed this issue by including src/objects-inl.h in src/compiler.h.
BUG=
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||