Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2282673002: [compiler] Avoid Gcc compilation fail by including src/objects-inl.h in src/compiler.h. (Closed)

Created:
4 years, 3 months ago by zhengxing.li
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Avoid Gcc compilation fail by including src/objects-inl.h in src/compiler.h. The CL #38926 (https://codereview.chromium.org/2281543002) removed #include "src/objects-inl.h" from src/compiler.h. This caused the Gcc compilation fail at the following code in src/objects.h, line 5329. The error message was: In file included from .././src/compilation-dependencies.h:9:0, from .././src/compiler.h:12, from ../src/compiler/pipeline-statistics.cc:7: .././src/objects.h:5329:23: error: inline function ‘static v8::internal::Code::Flags v8::internal::Code::ComputeFlags(v8::internal::Code::Kind, v8::internal::ExtraICState, v8::internal::CacheHolderFlag)’ used but never defined [-Werror] static inline Flags ComputeFlags( ^ cc1plus: all warnings being treated as errors The definition of ComputeFlags is in src/objects-inl.h. This CL fixed this issue by including src/objects-inl.h in src/compiler.h. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 3 months ago (2016-08-26 08:34:47 UTC) #2
zhengxing.li
PTAL, thanks!
4 years, 3 months ago (2016-08-26 08:35:21 UTC) #4
Michael Starzinger
4 years, 3 months ago (2016-08-26 08:38:32 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698