Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2281543002: [compiler] Remove inclusion of inline header file. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove inclusion of inline header file. R=marja@chromium.org Committed: https://crrev.com/b143cb09d04d3f408893e8272fe78c64b1b8f2bb Cr-Commit-Position: refs/heads/master@{#38926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -25 lines) Patch
M src/compiler.h View 5 chunks +10 lines, -25 lines 0 comments Download
M src/compiler.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M src/compiler/basic-block-instrumentor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/profiler/profile-generator.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
Please do not include inline headers into non-inline headers.
4 years, 3 months ago (2016-08-25 13:22:46 UTC) #1
marja
lgtm
4 years, 3 months ago (2016-08-26 07:20:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281543002/1
4 years, 3 months ago (2016-08-26 07:33:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 07:37:26 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 07:37:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b143cb09d04d3f408893e8272fe78c64b1b8f2bb
Cr-Commit-Position: refs/heads/master@{#38926}

Powered by Google App Engine
This is Rietveld 408576698