Implement structural function and array types

Implement structural function and array types

Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Committed: https://code.google.com/p/v8/source/detail?r=20815

Committed: https://code.google.com/p/v8/source/detail?r=20818

Committed: https://code.google.com/p/v8/source/detail?r=20819

[Benedikt Meurer, 2014-04-09 05:33:13]

https://codereview.chromium.org/228263005/diff/20001/src/types.h
File src/types.h (right):

https://codereview.chromium.org/228263005/diff/20001/src/types.h#newcode301
src/types.h:301: ClassType* AsClass() { return ClassType::cast(this); }
I really dislike this change. AsClass() and AsConstant() is already somewhat
cumbersome, but adding another level of indirection there makes it even worse,
esp. since ClassType and ConstantType do not provide any additional value in the
public API.

Let's chat about this offline...

[rossberg, 2014-04-09 10:59:25]

https://codereview.chromium.org/228263005/diff/20001/src/types.h
File src/types.h (right):

https://codereview.chromium.org/228263005/diff/20001/src/types.h#newcode301
src/types.h:301: ClassType* AsClass() { return ClassType::cast(this); }
On 2014/04/09 05:33:14, Benedikt Meurer wrote:
> I really dislike this change. AsClass() and AsConstant() is already somewhat
> cumbersome, but adding another level of indirection there makes it even worse,
> esp. since ClassType and ConstantType do not provide any additional value in
the
> public API.
> 
> Let's chat about this offline...

As discussed offline, I prefer the consistency. It's not used often enough to
make taking short cuts necessary.

[rossberg, 2014-04-14 15:17:50]

You could consider reviewing this... ;)

[rossberg, 2014-04-15 10:27:51]

Jarin, can you perhaps take a look?

[Benedikt Meurer, 2014-04-16 10:13:52]

LGTM

[rossberg, 2014-04-16 13:44:42]

Committed patchset #7 manually as r20809 (presubmit successful).

[rossberg, 2014-04-16 15:42:50]

Committed patchset #8 manually as r20815 (presubmit successful).

[rossberg, 2014-04-16 16:26:00]

Committed patchset #8 manually as r20818 (tree was closed).

[rossberg, 2014-04-16 16:36:34]

Committed patchset #8 manually as r20819 (tree was closed).