Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2282433002: Revert of cc: Delete all the RendererCapabilities. (Closed)

Created:
4 years, 3 months ago by johnme
Modified:
4 years, 3 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, Justin Novosad, Ken Russell (switch to Gerrit), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-prepare-mailbox-param
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Delete all the RendererCapabilities. (patchset #2 id:20001 of https://codereview.chromium.org/2267263002/ ) Reason for revert: This patch prevents reverting https://codereview.chromium.org/2280663002 Original issue's description: > cc: Delete all the RendererCapabilities. > > The one left that gets used is max_texture_size, for scrollbars. Since > painted scrollbars only happen on desktop, and we just make them blurry > if they exceed the max size, we just hardcode a limit of 2048 which > should be supported on any desktop device (it's guaranteed by DirectX9) > and we're fine with scrollbars becoming less than pixel-perfect if you > pinch zoom in and they become larger than max-texture-size anyhow. > > Everything else is unused or already deleted, so kill the structures > and the thread/ipc messages related to them. > > R=enne > BUG=606056 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/6484c37f7b2cfcaed90cc8a37677c670a75be023 > Cr-Commit-Position: refs/heads/master@{#414212} TBR=enne@chromium.org,danakj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606056 Committed: https://crrev.com/c2673922e67bcc2f32cc3ead89338672d62d952b Cr-Commit-Position: refs/heads/master@{#414408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -23 lines) Patch
M cc/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/layers/heads_up_display_layer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/delegating_renderer.h View 3 chunks +4 lines, -0 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/output/direct_renderer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.h View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 2 chunks +7 lines, -0 lines 0 comments Download
A cc/output/renderer_capabilities.h View 1 chunk +28 lines, -0 lines 0 comments Download
A cc/output/renderer_capabilities.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A cc/output/renderer_capabilities_impl.h View 1 chunk +27 lines, -0 lines 0 comments Download
A cc/output/renderer_capabilities_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M cc/output/software_renderer.h View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/output/vulkan_renderer.h View 2 chunks +4 lines, -1 line 0 comments Download
M cc/output/vulkan_renderer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/fake_channel_impl.h View 1 chunk +5 lines, -1 line 0 comments Download
M cc/test/fake_layer_tree_host.h View 3 chunks +9 lines, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 2 chunks +8 lines, -1 line 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/test/fake_proxy.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/trees/channel_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/proxy.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/proxy_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/proxy_impl.cc View 2 chunks +15 lines, -1 line 0 comments Download
M cc/trees/proxy_main.h View 4 chunks +7 lines, -1 line 0 comments Download
M cc/trees/proxy_main.cc View 3 chunks +20 lines, -4 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 4 chunks +11 lines, -2 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 5 chunks +16 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M cc/trees/threaded_channel.h View 1 chunk +5 lines, -1 line 0 comments Download
M cc/trees/threaded_channel.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
johnme
Created Revert of cc: Delete all the RendererCapabilities.
4 years, 3 months ago (2016-08-25 12:36:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282433002/1
4 years, 3 months ago (2016-08-25 12:36:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 12:38:02 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 12:39:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2673922e67bcc2f32cc3ead89338672d62d952b
Cr-Commit-Position: refs/heads/master@{#414408}

Powered by Google App Engine
This is Rietveld 408576698