Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2282403005: MD WebUI: Move history-lazy-render into cr-elements (Closed)

Created:
4 years, 3 months ago by tsergeant
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, michaelpg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Move history-lazy-render into cr-elements This is the first step in making this element usable by WebUI pages other than MD History. BUG=642200 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e2196439c06a665b58e24c1a6109639581a411b5 Cr-Commit-Position: refs/heads/master@{#418788}

Patch Set 1 #

Patch Set 2 : Closure #

Patch Set 3 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -279 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 2 2 chunks +47 lines, -47 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 5 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/resources/md_history/externs.js View 1 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/resources/md_history/lazy_render.html View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/md_history/lazy_render.js View 1 chunk +0 lines, -95 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.html View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/data/webui/cr_elements/cr_elements_browsertest.js View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/test/data/webui/cr_elements/cr_lazy_render_tests.js View 1 chunk +64 lines, -0 lines 0 comments Download
D chrome/test/data/webui/md_history/lazy_render_test.js View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 2 chunks +0 lines, -6 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_lazy_render/compiled_resources2.gyp View 1 1 chunk +1 line, -4 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.html View 1 chunk +1 line, -1 line 0 comments Download
A + ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js View 1 2 chunks +27 lines, -3 lines 2 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2344803002 Patch 1

Messages

Total messages: 18 (12 generated)
tsergeant
+dbeam to review, and CC michaelpg, who originally asked me to do this.
4 years, 3 months ago (2016-09-14 07:02:19 UTC) #9
Dan Beam
lgtm https://codereview.chromium.org/2282403005/diff/40001/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js File ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js (right): https://codereview.chromium.org/2282403005/diff/40001/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js#newcode41 ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js:41: TemplateInstance.prototype._notifyPath = function(path, value, quiet) {}; can we ...
4 years, 3 months ago (2016-09-14 20:34:39 UTC) #12
tsergeant
https://codereview.chromium.org/2282403005/diff/40001/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js File ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js (right): https://codereview.chromium.org/2282403005/diff/40001/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js#newcode41 ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js:41: TemplateInstance.prototype._notifyPath = function(path, value, quiet) {}; On 2016/09/14 20:34:39, ...
4 years, 3 months ago (2016-09-15 04:58:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282403005/40001
4 years, 3 months ago (2016-09-15 04:59:24 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 05:16:37 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 05:18:56 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e2196439c06a665b58e24c1a6109639581a411b5
Cr-Commit-Position: refs/heads/master@{#418788}

Powered by Google App Engine
This is Rietveld 408576698