Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 22824016: Fix for nested rect drawing bug (Closed)

Created:
7 years, 4 months ago by robertphillips
Modified:
7 years, 3 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This CL fixes crbug.com 273121 (regression in canvas 2d fill with rect and inverted winding rect) and adds a GM that would've caught the problem.

Patch Set 1 #

Patch Set 2 : Gussied up a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -8 lines) Patch
A gm/nested.cpp View 1 1 chunk +125 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
7 years, 4 months ago (2013-08-16 19:31:00 UTC) #1
bsalomon
The logic for determining whether it the path is nested rects is feeling like it ...
7 years, 4 months ago (2013-08-18 20:32:49 UTC) #2
robertphillips
I think that's a good idea (having a PathRenderer subclass that collects the special cases). ...
7 years, 4 months ago (2013-08-19 13:06:15 UTC) #3
bsalomon
On 2013/08/19 13:06:15, robertphillips wrote: > I think that's a good idea (having a PathRenderer ...
7 years, 4 months ago (2013-08-19 13:19:45 UTC) #4
robertphillips
committed as r10803
7 years, 4 months ago (2013-08-20 12:11:51 UTC) #5
robertphillips
Actually committed as r10804
7 years, 3 months ago (2013-08-28 13:45:13 UTC) #6
robertphillips
7 years, 3 months ago (2013-08-28 13:50:51 UTC) #7
Message was sent while issue was closed.
Merged into Chromium M30 branch at r10962
(https://code.google.com/p/skia/source/detail?r=10962)

Powered by Google App Engine
This is Rietveld 408576698