Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2282273002: Remove the obsolete MinidumpDirectoryObserver experiment. (Closed)

Created:
4 years, 3 months ago by Ilya Sherman
Modified:
4 years, 3 months ago
Reviewers:
nikunjb1, Yaron, gone, Menglin
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the obsolete MinidumpDirectoryObserver experiment. This experiment is rolled out to 100% of users server-side, so: (1) Update the client code to default to the new code path, and (2) Remove the old code path, which is no longer reachable. BUG=none TEST=none R=mlliu@chromium.org Committed: https://crrev.com/5d908b661555676046e3b47e4d0c8ed6050130c8 Cr-Commit-Position: refs/heads/master@{#415780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -56 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 3 chunks +12 lines, -18 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 5 chunks +0 lines, -28 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
Ilya Sherman
4 years, 3 months ago (2016-08-27 00:54:42 UTC) #1
Ilya Sherman
+Dan for OWNERS
4 years, 3 months ago (2016-08-27 00:55:29 UTC) #4
Menglin
+ nikunjb@ the finch ambassador who helped me on experiment related stuff when i set ...
4 years, 3 months ago (2016-08-27 01:00:34 UTC) #7
gone
Did you want me to take a look at this, or did you want to ...
4 years, 3 months ago (2016-08-29 17:28:10 UTC) #10
Menglin
On 2016/08/29 17:28:10, dfalcantara wrote: > Did you want me to take a look at ...
4 years, 3 months ago (2016-08-29 17:30:18 UTC) #11
gone
lgtm Looks like it'll always just be true, so I guess this seems fine. Can ...
4 years, 3 months ago (2016-08-29 18:12:26 UTC) #12
Ilya Sherman
On 2016/08/29 18:12:26, dfalcantara wrote: > lgtm > > Looks like it'll always just be ...
4 years, 3 months ago (2016-08-29 19:02:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282273002/1
4 years, 3 months ago (2016-08-29 19:49:08 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/288426)
4 years, 3 months ago (2016-08-30 03:37:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282273002/1
4 years, 3 months ago (2016-08-31 21:43:56 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 22:23:45 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:27:12 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d908b661555676046e3b47e4d0c8ed6050130c8
Cr-Commit-Position: refs/heads/master@{#415780}

Powered by Google App Engine
This is Rietveld 408576698