Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: net/cert/internal/path_builder.cc

Issue 2282183004: Add error information to VerifyCertificateChain(). (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/path_builder.cc
diff --git a/net/cert/internal/path_builder.cc b/net/cert/internal/path_builder.cc
index 10b507bc594c3849d63aa2af78c35ad8a1c5d08a..fad4a70e63fcbcc93f332edd13784803dedf05aa 100644
--- a/net/cert/internal/path_builder.cc
+++ b/net/cert/internal/path_builder.cc
@@ -635,10 +635,12 @@ CompletionStatus CertPathBuilder::DoGetNextPathComplete() {
return CompletionStatus::SYNC;
}
+ // TODO(crbug.com/634443): Expose CertErrors on ResultPath.
mattm 2016/08/29 22:15:11 I guess there would also be a CertErrors on the Re
eroman 2016/08/29 22:55:18 Yes, I expect so. (This TODO was specifically abo
+ CertErrors errors;
bool verify_result =
next_path_.trust_anchor.get() &&
VerifyCertificateChain(next_path_.certs, next_path_.trust_anchor.get(),
- signature_policy_, time_);
+ signature_policy_, time_, &errors);
DVLOG(1) << "CertPathBuilder VerifyCertificateChain result = "
<< verify_result;
AddResultPath(next_path_, verify_result);

Powered by Google App Engine
This is Rietveld 408576698