Add error information to VerifyCertificateChain().

net/cert/internal/path_builder.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/path_builder.h"
 
 #include <set>
 #include <unordered_set>
 
 #include "base/callback_helpers.h"
@@ skipping 617 matching lines @@
     base::ResetAndReturn(&callback_).Run();
 }
 
 CompletionStatus CertPathBuilder::DoGetNextPathComplete() {
   if (next_path_.IsEmpty()) {
     // No more paths to check, signal completion.
     next_state_ = STATE_NONE;
     return CompletionStatus::SYNC;
   }
 
+  //  TODO(crbug.com/634443): Expose CertErrors on ResultPath.

[mattm, 2016/08/29 22:15:11]

I guess there would also be a CertErrors on the Result for errors not associated
with a specific path?

[eroman, 2016/08/29 22:55:18]

Yes, I expect so.

(This TODO was specifically about this callsite, where |errors| is otherwise
unused).

+  CertErrors errors;
   bool verify_result =
       next_path_.trust_anchor.get() &&
       VerifyCertificateChain(next_path_.certs, next_path_.trust_anchor.get(),
-                             signature_policy_, time_);
+                             signature_policy_, time_, &errors);
   DVLOG(1) << "CertPathBuilder VerifyCertificateChain result = "
            << verify_result;
   AddResultPath(next_path_, verify_result);
 
   if (verify_result) {
     // Found a valid path, return immediately.
     // TODO(mattm): add debug/test mode that tries all possible paths.
     next_state_ = STATE_NONE;
     return CompletionStatus::SYNC;
   }
@@ skipping 11 matching lines @@
   result_path->error = is_success ? OK : ERR_CERT_AUTHORITY_INVALID;
   // TODO(mattm): set best_result_index based on number or severity of errors.
   if (result_path->error == OK)
     out_result_->best_result_index = out_result_->paths.size();
   // TODO(mattm): add flag to only return a single path or all attempted paths?
   result_path->path = path;
   out_result_->paths.push_back(std::move(result_path));
 }
 
 }  // namespace net