Issue 2282183002: android: Move CleanupReference to android_webview

Issue 2282183002: android: Move CleanupReference to android_webview (Closed)

Created:
4 years, 3 months ago by boliu

Modified:
4 years, 3 months ago

Reviewers:
Ted C

CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

android: Move CleanupReference to android_webview BUG=507405 Committed: https://crrev.com/4f08899f63210bbc079def9b6fb9da9dd423012b Cr-Commit-Position: refs/heads/master@{#415311}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -286 lines)			Patch
M	android_webview/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwGLFunctor.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/AwPicture.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
A +	android_webview/java/src/org/chromium/android_webview/CleanupReference.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/permission/AwGeolocationCallback.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	android_webview/java/src/org/chromium/android_webview/permission/AwPermissionRequest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	android_webview/javatests/src/org/chromium/android_webview/test/CleanupReferenceTest.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	android_webview/test/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/android/BUILD.gn	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	content/public/android/java/src/org/chromium/content/common/CleanupReference.java	View	1 chunk	+0 lines, -169 lines	0 comments	Download
D	content/public/android/javatests/src/org/chromium/content/common/CleanupReferenceTest.java	View	1 chunk	+0 lines, -107 lines	0 comments	Download

Total messages: 8 (3 generated)

boliu

ptal depends on https://codereview.chromium.org/2282153002/ which removes the last usage from chrome

4 years, 3 months ago (2016-08-29 21:24:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282183002/1

4 years, 3 months ago (2016-08-30 13:35:57 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-08-30 16:12:35 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4f08899f63210bbc079def9b6fb9da9dd423012b
Cr-Commit-Position: refs/heads/master@{#415311}