Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2282063002: [Extensions] Convert some SyncExtensionFunctions (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some SyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove SyncExtensionFunctions from: - idltest - test - system_display BUG=634140 Committed: https://crrev.com/00504c4c50062062945eaa7e588a310cfb1032a4 Cr-Commit-Position: refs/heads/master@{#415143}

Patch Set 1 #

Total comments: 4

Patch Set 2 : lazyboy's #

Total comments: 4

Patch Set 3 : test #

Patch Set 4 : revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -177 lines) Patch
M chrome/browser/extensions/api/idltest/idltest_api.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_api.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.h View 1 9 chunks +19 lines, -12 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.cc View 1 3 1 chunk +76 lines, -114 lines 0 comments Download
M extensions/browser/api/test/test_api.h View 6 chunks +13 lines, -15 lines 0 comments Download
M extensions/browser/api/test/test_api.cc View 3 chunks +19 lines, -21 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
Devlin
4 years, 3 months ago (2016-08-26 22:39:07 UTC) #6
lazyboy
https://codereview.chromium.org/2282063002/diff/1/extensions/browser/api/system_display/system_display_api.cc File extensions/browser/api/system_display/system_display_api.cc (right): https://codereview.chromium.org/2282063002/diff/1/extensions/browser/api/system_display/system_display_api.cc#newcode59 extensions/browser/api/system_display/system_display_api.cc:59: #if !defined(OS_CHROMEOS) As 8 out of 9 functions in ...
4 years, 3 months ago (2016-08-26 23:13:16 UTC) #7
Devlin
https://codereview.chromium.org/2282063002/diff/1/extensions/browser/api/system_display/system_display_api.cc File extensions/browser/api/system_display/system_display_api.cc (right): https://codereview.chromium.org/2282063002/diff/1/extensions/browser/api/system_display/system_display_api.cc#newcode59 extensions/browser/api/system_display/system_display_api.cc:59: #if !defined(OS_CHROMEOS) On 2016/08/26 23:13:16, lazyboy wrote: > As ...
4 years, 3 months ago (2016-08-29 16:05:57 UTC) #12
lazyboy
lgtm. https://codereview.chromium.org/2282063002/diff/20001/extensions/browser/api/system_display/system_display_api.cc File extensions/browser/api/system_display/system_display_api.cc (right): https://codereview.chromium.org/2282063002/diff/20001/extensions/browser/api/system_display/system_display_api.cc#newcode34 extensions/browser/api/system_display/system_display_api.cc:34: #else nit: no need for #else block, just ...
4 years, 3 months ago (2016-08-29 18:03:05 UTC) #13
Devlin
https://codereview.chromium.org/2282063002/diff/20001/extensions/browser/api/system_display/system_display_api.cc File extensions/browser/api/system_display/system_display_api.cc (right): https://codereview.chromium.org/2282063002/diff/20001/extensions/browser/api/system_display/system_display_api.cc#newcode34 extensions/browser/api/system_display/system_display_api.cc:34: #else On 2016/08/29 18:03:05, lazyboy wrote: > nit: no ...
4 years, 3 months ago (2016-08-29 20:22:26 UTC) #17
lazyboy
still lgtm. https://codereview.chromium.org/2282063002/diff/20001/extensions/browser/api/system_display/system_display_api.cc File extensions/browser/api/system_display/system_display_api.cc (right): https://codereview.chromium.org/2282063002/diff/20001/extensions/browser/api/system_display/system_display_api.cc#newcode34 extensions/browser/api/system_display/system_display_api.cc:34: #else On 2016/08/29 20:22:25, Devlin wrote: > ...
4 years, 3 months ago (2016-08-29 21:31:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282063002/60001
4 years, 3 months ago (2016-08-29 22:22:34 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 05:15:39 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:20:08 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/00504c4c50062062945eaa7e588a310cfb1032a4
Cr-Commit-Position: refs/heads/master@{#415143}

Powered by Google App Engine
This is Rietveld 408576698