[Extensions] Convert some SyncExtensionFunctions

extensions/browser/api/test/test_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/test/test_api.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
@@ skipping 20 matching lines @@
 
 namespace extensions {
 
 namespace Log = api::test::Log;
 namespace NotifyFail = api::test::NotifyFail;
 namespace PassMessage = api::test::PassMessage;
 namespace WaitForRoundTrip = api::test::WaitForRoundTrip;
 
 TestExtensionFunction::~TestExtensionFunction() {}
 
-bool TestExtensionFunction::RunSync() {
+bool TestExtensionFunction::PreRunValidation(std::string* error) {
+  if (!UIThreadExtensionFunction::PreRunValidation(error))
+    return false;
   if (!base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType)) {
-    error_ = kNotTestProcessError;
+    *error = kNotTestProcessError;
     return false;
   }
-  return RunSafe();
+  return true;
 }
 
 TestNotifyPassFunction::~TestNotifyPassFunction() {}
 
-bool TestNotifyPassFunction::RunSafe() {
+ExtensionFunction::ResponseAction TestNotifyPassFunction::Run() {
   content::NotificationService::current()->Notify(
       extensions::NOTIFICATION_EXTENSION_TEST_PASSED,
       content::Source<content::BrowserContext>(dispatcher()->browser_context()),
       content::NotificationService::NoDetails());
-  return true;
+  return RespondNow(NoArguments());
 }
 
 TestNotifyFailFunction::~TestNotifyFailFunction() {}
 
-bool TestNotifyFailFunction::RunSafe() {
+ExtensionFunction::ResponseAction TestNotifyFailFunction::Run() {
   std::unique_ptr<NotifyFail::Params> params(
       NotifyFail::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
   content::NotificationService::current()->Notify(
       extensions::NOTIFICATION_EXTENSION_TEST_FAILED,
       content::Source<content::BrowserContext>(dispatcher()->browser_context()),
       content::Details<std::string>(&params->message));
-  return true;
+  return RespondNow(NoArguments());
 }
 
 TestLogFunction::~TestLogFunction() {}
 
-bool TestLogFunction::RunSafe() {
+ExtensionFunction::ResponseAction TestLogFunction::Run() {
   std::unique_ptr<Log::Params> params(Log::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
   VLOG(1) << params->message;
-  return true;
+  return RespondNow(NoArguments());
 }
 
 TestSendMessageFunction::TestSendMessageFunction() : waiting_(false) {}
 
 ExtensionFunction::ResponseAction TestSendMessageFunction::Run() {
   std::unique_ptr<PassMessage::Params> params(
       PassMessage::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
   bool listener_will_respond = false;
   std::pair<std::string, bool*> details(params->message,
@@ skipping 43 matching lines @@
     : config_state_(NULL) {}
 
 // static
 TestGetConfigFunction::TestConfigState*
 TestGetConfigFunction::TestConfigState::GetInstance() {
   return base::Singleton<TestConfigState>::get();
 }
 
 TestGetConfigFunction::~TestGetConfigFunction() {}
 
-bool TestGetConfigFunction::RunSafe() {
+ExtensionFunction::ResponseAction TestGetConfigFunction::Run() {
   TestConfigState* test_config_state = TestConfigState::GetInstance();
-
-  if (!test_config_state->config_state()) {
-    error_ = kNoTestConfigDataError;
-    return false;
-  }
-
-  SetResult(test_config_state->config_state()->CreateDeepCopy());
-  return true;
+  if (!test_config_state->config_state())
+    return RespondNow(Error(kNoTestConfigDataError));
+  return RespondNow(
+      OneArgument(test_config_state->config_state()->CreateDeepCopy()));
 }
 
 TestWaitForRoundTripFunction::~TestWaitForRoundTripFunction() {}
 
-bool TestWaitForRoundTripFunction::RunSafe() {
+ExtensionFunction::ResponseAction TestWaitForRoundTripFunction::Run() {
   std::unique_ptr<WaitForRoundTrip::Params> params(
       WaitForRoundTrip::Params::Create(*args_));
-  SetResult(base::MakeUnique<base::StringValue>(params->message));
-  return true;
+  return RespondNow(
+      OneArgument(base::MakeUnique<base::StringValue>(params->message)));
 }
 
 }  // namespace extensions