Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3030)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2281963002: Use -fdiagnostics-absolute-paths in Win-Clang builds (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index aa22d90bfdec0c78ae06ef1d3b7b62a41e75751e..83132ae8edeef328b862bc7cfae4955df4ebaccb 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -372,6 +372,12 @@ config("compiler") {
cflags += [ "-fcolor-diagnostics" ]
}
+ # Windows devs want absolute paths in diagnostics (crbug.com/636109).
Nico 2016/08/26 17:06:24 Maybe you can expand this a bit based on discussio
hans 2016/08/26 20:50:06 Done.
+ # TODO(hans) Remove llvm_force_head_revision check in next clang roll.
+ if (is_clang && is_win && llvm_force_head_revision) {
Nico 2016/08/26 16:13:01 Should we do this on all platforms? Seems a bit ar
hans 2016/08/26 16:21:43 I agree it might seem a bit odd to do it on only o
scottmg 2016/08/26 16:58:34 Yeah, I would agree with keeping it Windows-only.
+ cflags += [ "-fdiagnostics-absolute-paths" ]
+ }
+
# Makes builds independent of absolute file path.
# clang-cl (used if is_win) doesn't expose this flag.
# Currently disabled for nacl since its toolchain lacks this flag (too old).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698