Use -fdiagnostics-absolute-paths in Win-Clang builds

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/nacl/config.gni")
 import("//build/toolchain/cc_wrapper.gni")
 import("//build/toolchain/toolchain.gni")
@@ skipping 354 matching lines @@
   if (linux_use_bundled_binutils) {
     cflags += [ "-B$binutils_path" ]
   }
 
   # Clang-specific compiler flags setup.
   # ------------------------------------
   if (is_clang) {
     cflags += [ "-fcolor-diagnostics" ]
   }
 
+  # Windows devs want absolute paths in diagnostics (crbug.com/636109).

[Nico, 2016/08/26 17:06:24]

Maybe you can expand this a bit based on discussion ("why only windows?)"

[hans, 2016/08/26 20:50:06]

Done.

+  # TODO(hans) Remove llvm_force_head_revision check in next clang roll.
+  if (is_clang && is_win && llvm_force_head_revision) {

[Nico, 2016/08/26 16:13:01]

Should we do this on all platforms? Seems a bit arbitrary to do this on Windows
but not elsewhere.

[hans, 2016/08/26 16:21:43]

I agree it might seem a bit odd to do it on only one platform, but I think the
desire for this is very Windows-specific.

Personally I prefer relative paths, and I think this is very natural to most
Linux and Mac folks too.

I guess what it boils down to is that there's no precedence for absolute paths
in diagnostics on Unix (GCC doesn't do it), but there is on Windows and those
developers seem to expect it.

[scottmg, 2016/08/26 16:58:34]

Yeah, I would agree with keeping it Windows-only. Even though it's a bit odd, 
with /FC in gyp/gn it's been different on both platforms for a long time.

(We have /FC on when running like this, right? Does this also need to be turned
on explicitly still for clang-cl?)

+    cflags += [ "-fdiagnostics-absolute-paths" ]
+  }
+
   # Makes builds independent of absolute file path.
   # clang-cl (used if is_win) doesn't expose this flag.
   # Currently disabled for nacl since its toolchain lacks this flag (too old).
   # TODO(zforman): Once nacl's toolchain is updated, remove check.
   if (is_clang && is_linux) {
     absolute_path = rebase_path("//.")
     cflags += [ "-fdebug-prefix-map=$absolute_path=." ]
   }
 
   # C++11 compiler flags setup.
@@ skipping 1199 matching lines @@
 
 if (is_ios || is_mac) {
   # On Mac and iOS, this enables support for ARC (automatic ref-counting).
   # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
   config("enable_arc") {
     common_flags = [ "-fobjc-arc" ]
     cflags_objc = common_flags
     cflags_objcc = common_flags
   }
 }