Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2281803002: [ios] Removed deprecated JS execution API. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed deprecated JS execution API. BUG=595761 Committed: https://crrev.com/62d6b4824ad8e0b4668be8baf32d0893a28f8e5a Cr-Commit-Position: refs/heads/master@{#415406}

Patch Set 1 #

Patch Set 2 : Fixed tests #

Patch Set 3 : Merged with master #

Patch Set 4 : Merged with master #

Patch Set 5 : Merged with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -206 lines) Patch
M ios/web/interstitials/html_web_interstitial_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/interstitials/html_web_interstitial_impl.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/web/interstitials/native_web_interstitial_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/interstitials/native_web_interstitial_impl.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/web/interstitials/web_interstitial_impl.h View 3 chunks +0 lines, -19 lines 0 comments Download
M ios/web/public/block_types.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web/public/test/crw_test_js_injection_receiver.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web/public/web_state/js/crw_js_injection_evaluator.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ios/web/public/web_state/js/crw_js_injection_manager.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/web/web_state/js/crw_js_injection_manager.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web/web_state/js/crw_js_injection_receiver.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M ios/web/web_state/ui/web_view_js_utils.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/web/web_state/ui/web_view_js_utils.mm View 2 chunks +0 lines, -44 lines 0 comments Download
M ios/web/web_state/ui/web_view_js_utils_unittest.mm View 1 7 chunks +8 lines, -72 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Eugene But (OOO till 7-30)
4 years, 3 months ago (2016-08-30 18:58:43 UTC) #11
Jackie Quinn
lgtm
4 years, 3 months ago (2016-08-30 19:15:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281803002/80001
4 years, 3 months ago (2016-08-30 20:10:12 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-30 20:15:55 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 20:17:18 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/62d6b4824ad8e0b4668be8baf32d0893a28f8e5a
Cr-Commit-Position: refs/heads/master@{#415406}

Powered by Google App Engine
This is Rietveld 408576698