Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: ios/web/interstitials/web_interstitial_impl.h

Issue 2281803002: [ios] Removed deprecated JS execution API. (Closed)
Patch Set: Merged with master Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/interstitials/native_web_interstitial_impl.mm ('k') | ios/web/public/block_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/interstitials/web_interstitial_impl.h
diff --git a/ios/web/interstitials/web_interstitial_impl.h b/ios/web/interstitials/web_interstitial_impl.h
index dcc02d6ee11bad3d151e68315dca8b4c6aa1f17a..cc7607512e8795de492bdf720250d0346ae6c399 100644
--- a/ios/web/interstitials/web_interstitial_impl.h
+++ b/ios/web/interstitials/web_interstitial_impl.h
@@ -22,13 +22,6 @@ class WebInterstitialImpl;
class WebStateImpl;
// May be implemented in tests to run JavaScript on interstitials. This function
-// has access to private EvaluateJavaScript method to be used for testing.
-// DEPRECATED. TODO(crbug.com/595761): Remove this function.
-void EvaluateScriptForTesting(WebInterstitialImpl*,
- NSString*,
- JavaScriptCompletion);
-
-// May be implemented in tests to run JavaScript on interstitials. This function
// has access to private ExecuteJavaScript method to be used for testing.
void ExecuteScriptForTesting(WebInterstitialImpl*,
NSString*,
@@ -74,13 +67,6 @@ class WebInterstitialImpl : public WebInterstitial, public WebStateObserver {
// Convenience method for getting the WebStateImpl.
WebStateImpl* GetWebStateImpl() const;
- // Evaluates the given |script| on interstitial's web view if there is one.
- // Calls |completionHandler| with results of the evaluation.
- // The |completionHandler| can be nil. Must be used only for testing.
- // DEPRECATED. TODO(crbug.com/595761): Remove this method.
- virtual void EvaluateJavaScript(NSString* script,
- JavaScriptCompletion completionHandler) = 0;
-
// Executes the given |script| on interstitial's web view if there is one.
// Calls |completionHandler| with results of the evaluation.
// The |completionHandler| can be nil. Must be used only for testing.
@@ -101,11 +87,6 @@ class WebInterstitialImpl : public WebInterstitial, public WebStateObserver {
bool action_taken_;
// Must be implemented only for testing purposes.
- // DEPRECATED. TODO(crbug.com/595761): Remove this function.
- friend void web::EvaluateScriptForTesting(WebInterstitialImpl*,
- NSString*,
- JavaScriptCompletion);
- // Must be implemented only for testing purposes.
friend void web::ExecuteScriptForTesting(WebInterstitialImpl*,
NSString*,
JavaScriptResultBlock);
« no previous file with comments | « ios/web/interstitials/native_web_interstitial_impl.mm ('k') | ios/web/public/block_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698