Rework CFX_CountRef in terms of CFX_RetainPtr

Rework CFX_CountRef in terms of CFX_RetainPtr.

Make use of existing ref count work rather than re-inventing it.

Committed: https://pdfium.googlesource.com/pdfium/+/80f9957fe156bd8e940499491ca8167fe7dad416

[Tom Sepez, 2016-08-25 18:16:58]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 18:17:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-25 19:02:42]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 19:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 19:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 19:04:01]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)
  mac on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/1789)

[Tom Sepez, 2016-08-25 19:04:05]

Description was changed from

==========
rework CFX_CountRef in terms of CFX_RetainPtr
==========

to

==========
Rework CFX_CountRef in terms of CFX_RetainPtr.

Make use of existing ref count work rather than re-inventing it.
==========

[Tom Sepez, 2016-08-25 19:04:06]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-08-25 19:06:50]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 19:07:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-25 19:08:38]

Lei, for review.  Start with PS#2, the rest is just moving things around.

[commit-bot: I haz the power, 2016-08-25 19:20:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 19:20:32]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-25 22:45:57]

Looks ok. Should we add some unit tests?

[Tom Sepez, 2016-08-26 00:04:41]

On 2016/08/25 22:45:57, Lei Zhang wrote:
> Looks ok. Should we add some unit tests?

Tests.

[Lei Zhang, 2016-08-26 00:41:51]

lgtm

[Tom Sepez, 2016-08-26 17:30:05]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 17:30:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-26 17:37:13]

Lei, tinkering, also add test for "Copy On Write" path.

[Lei Zhang, 2016-08-26 17:43:10]

even better, still lgtm

[Tom Sepez, 2016-08-26 17:47:37]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-08-26 17:47:42]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-08-26 17:47:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 17:59:06]

Description was changed from

==========
Rework CFX_CountRef in terms of CFX_RetainPtr.

Make use of existing ref count work rather than re-inventing it.
==========

to

==========
Rework CFX_CountRef in terms of CFX_RetainPtr.

Make use of existing ref count work rather than re-inventing it.

Committed:
https://pdfium.googlesource.com/pdfium/+/80f9957fe156bd8e940499491ca8167fe7da...
==========

[commit-bot: I haz the power, 2016-08-26 17:59:08]

Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/80f9957fe156bd8e940499491ca8167fe7da...