core/fpdfapi/fpdf_page/include/cpdf_path.h - Issue 2281683002: Rework CFX_CountRef in terms of CFX_RetainPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/include/cpdf_path.h

Issue 2281683002: Rework CFX_CountRef in terms of CFX_RetainPtr (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add test that GetModify() may construct a duplicate Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/include/cpdf_path.h

diff --git a/core/fpdfapi/fpdf_page/include/cpdf_path.h b/core/fpdfapi/fpdf_page/include/cpdf_path.h

index 0c077bb4432833026f51eb0acdb454e0235aefce..0e8c491f9e34c3b61f5a5e34b101345fc44ebf3f 100644

--- a/core/fpdfapi/fpdf_page/include/cpdf_path.h

+++ b/core/fpdfapi/fpdf_page/include/cpdf_path.h

@@ -27,8 +27,8 @@ class CPDF_Path : public CFX_CountRef<CFX_PathData> {

FX_BOOL IsRect() const { return m_pObject->IsRect(); }

void Transform(const CFX_Matrix* pMatrix) { GetModify()->Transform(pMatrix); }

- void Append(CPDF_Path src, const CFX_Matrix* pMatrix) {

- m_pObject->Append(src.m_pObject, pMatrix);

+ void Append(const CPDF_Path& other, const CFX_Matrix* pMatrix) {

+ m_pObject->Append(other.GetObject(), pMatrix);

}

void AppendRect(FX_FLOAT left,

« no previous file with comments | « core/fpdfapi/fpdf_page/cpdf_contentmark.h ('k') | core/fxcrt/cfx_count_ref_unittest.cpp » ('j') | no next file with comments »