Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2281643003: Move animVal invalidation from SVGAnimateElement to SVGElement (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move animVal invalidation from SVGAnimateElement to SVGElement BUG=640676 Committed: https://crrev.com/d3d278956414b3921db701fcd575e41841440ed7 Cr-Commit-Position: refs/heads/master@{#414543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 3 chunks +16 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2285473002 Patch 1
Issue 2285473002 Patch 20001

Messages

Total messages: 12 (7 generated)
fs
4 years, 3 months ago (2016-08-25 20:09:28 UTC) #4
pdr.
On 2016/08/25 at 20:09:28, fs wrote: > LGTM
4 years, 3 months ago (2016-08-25 20:23:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281643003/1
4 years, 3 months ago (2016-08-25 21:16:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 21:22:40 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 21:24:14 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d3d278956414b3921db701fcd575e41841440ed7
Cr-Commit-Position: refs/heads/master@{#414543}

Powered by Google App Engine
This is Rietveld 408576698