Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2281353002: [CUPS] Implement the Add Printer dialogs. (Closed)

Created:
4 years, 3 months ago by xdai1
Modified:
4 years, 3 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Implement the Add Printer dialogs. - Implement the discovery dialog. - Implement the manually add printer dialog. - Implement the configuring-in-progress dialog. Note the APIs is not ready yet, So these are just UI dialogs and not functional. BUG=626752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f5c87797ec6b0b20b40e599b2cba2f6971280ce3 Cr-Commit-Position: refs/heads/master@{#415983}

Patch Set 1 #

Total comments: 24

Patch Set 2 : Address michaelpg@'s comments. #

Total comments: 6

Patch Set 3 : Address michaelpg@'s comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+584 lines, -38 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +34 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/compiled_resources2.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 2 1 chunk +190 lines, -23 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 1 2 1 chunk +215 lines, -6 lines 0 comments Download
A chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js View 1 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printer_details_page.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printers.html View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printers_list.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
4 years, 3 months ago (2016-08-26 23:58:18 UTC) #4
michaelpg
https://codereview.chromium.org/2281353002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2281353002/diff/1/chrome/app/settings_strings.grdp#newcode768 chrome/app/settings_strings.grdp:768: <message name="IDS_SETTINGS_PRINTING_CUPS_PRINTER_DETAILS_QUEUE" desc="Lable for the CUPS printer queue in ...
4 years, 3 months ago (2016-08-29 17:10:33 UTC) #7
xdai1
michaelpg@, I've addressed your comments. Please take another look, thanks! https://codereview.chromium.org/2281353002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2281353002/diff/1/chrome/app/settings_strings.grdp#newcode768 ...
4 years, 3 months ago (2016-08-29 18:45:46 UTC) #8
michaelpg
lgtm https://codereview.chromium.org/2281353002/diff/20001/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html File chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html (right): https://codereview.chromium.org/2281353002/diff/20001/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html#newcode72 chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html:72: --paper-input-container-color: rgb(192, 199, 205); where does this color ...
4 years, 3 months ago (2016-08-31 16:59:57 UTC) #9
xdai1
michaelpg@, I've addressed your comments. Thanks for your review! https://codereview.chromium.org/2281353002/diff/20001/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html File chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html (right): https://codereview.chromium.org/2281353002/diff/20001/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html#newcode72 chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html:72: ...
4 years, 3 months ago (2016-09-01 00:00:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281353002/40001
4 years, 3 months ago (2016-09-01 00:01:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/285440)
4 years, 3 months ago (2016-09-01 01:20:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281353002/40001
4 years, 3 months ago (2016-09-01 16:22:09 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-01 17:15:09 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 17:17:31 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f5c87797ec6b0b20b40e599b2cba2f6971280ce3
Cr-Commit-Position: refs/heads/master@{#415983}

Powered by Google App Engine
This is Rietveld 408576698