chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html - Issue 2281353002: [CUPS] Implement the Add Printer dialogs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

Issue 2281353002: [CUPS] Implement the Add Printer dialogs. (Closed)

Patch Set: Address michaelpg@'s comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js ('K') | « chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js ('k') | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">

	2 <link rel="import" href="chrome://resources/html/polymer.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	5 <link rel="import" href="/printing_page/cups_printers_browser_proxy.html">

	6 <link rel="import" href="/settings_shared_css.html">

	7

	8 <dom-module id="add-printer-list">

	9 <template>

	10 <style include="settings-shared">

	11 .list-frame {

	12 -webkit-padding-end: 0;

	13 -webkit-padding-start: 0;

	14 }

	15

	16 .list-item {

	17 -webkit-padding-start: 20px;

	18 min-height: 35px;

	19 }

	20 </style>

	21 <div class="list-frame">

	22 <array-selector id="arraySelector" items="[[printers]]"

	23 selected="{{selectedPrinter}}">

	24 </array-selector>

	25 <template is="dom-repeat" items="[[printers]]">

	26 <paper-item class="list-item" on-tap="onSelect_">

	27 [[item.printerName]] [[item.printerModel]]

	28 </paper-item>

	29 </template>

	30 </div>

	31 </template>

	32 </dom-module>

	33

	34 <dom-module id="add-printer-dialog">

	35 <template>

	36 <style include="settings-shared">

	37 #dialog .body {

	38 -webkit-padding-end: 0;

	39 -webkit-padding-start: 0;

	40 height: 350px;

	41 }

	42

	43 #dialog .button-container {

	44 border-top: 1px solid rgba(0, 0, 0, 0.14);

	45 margin-top: 0;

	46 padding-top: 10px;

	47 }

	48

	49 #dialog .button-container ::content paper-button {

	50 font-size: 14px;

	51 font-weight: bold;

	52 }

	53 </style>

	54

	55 <dialog is="cr-dialog" id="dialog">

	56 <div class="title">$i18n{addPrinterTitle}</div>

	57 <div class="body">

	58 <content select=".dialog-body"></content>

	59 </div>

	60 <div class="button-container">

	61 <content select=".dialog-button"></content>
	michaelpg 2016/08/31 16:59:57 nit: make the class "dialog-buttons" (plural) nit: make the class "dialog-buttons" (plural) xdai1 2016/09/01 00:00:19 Done. Show quoted text On 2016/08/31 16:59:57, michaelpg wrote: > nit: make the class "dialog-buttons" (plural) Done.
	62 </div>

	63 </dialog>

	64 </template>

	65 <script src="cups_add_printer_dialog_util.js"></script>

	66 </dom-module>

OLD	NEW