Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2281273002: Add support to Document::getAnnots method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months ago by tonikitoo
Modified:
9 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add support to Document::getAnnots method Although notably, the parameters handling support is not complete, CL intends to be the first step towards a more complete implementation of this API. TEST=testing/resources/javascript/bug_492_1.in BUG=pdfium:492 Committed: https://pdfium.googlesource.com/pdfium/+/0ee35908e906922a423fb18d7085ef80d0d8d8c8

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed nit as per tsepez's request #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -5 lines) Patch
M fpdfsdk/javascript/Document.cpp View 1 chunk +42 lines, -1 line 0 comments Download
A testing/resources/javascript/bug_492_1.in View 1 1 chunk +95 lines, -0 lines 0 comments Download
A testing/resources/javascript/bug_492_1_expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/resources/javascript/document_methods.in View 1 3 chunks +8 lines, -1 line 0 comments Download
M testing/resources/javascript/document_methods_expected.txt View 2 chunks +1 line, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 10 (5 generated)
tonikitoo
PTAL
9 months ago (2016-08-26 20:52:22 UTC) #3
Tom Sepez
Very nice. LGTM with style nit. https://codereview.chromium.org/2281273002/diff/1/testing/resources/javascript/bug_492_1.in File testing/resources/javascript/bug_492_1.in (right): https://codereview.chromium.org/2281273002/diff/1/testing/resources/javascript/bug_492_1.in#newcode66 testing/resources/javascript/bug_492_1.in:66: /QuadPoints [ 115.80264 ...
9 months ago (2016-08-26 21:10:06 UTC) #4
tonikitoo
https://codereview.chromium.org/2281273002/diff/1/testing/resources/javascript/bug_492_1.in File testing/resources/javascript/bug_492_1.in (right): https://codereview.chromium.org/2281273002/diff/1/testing/resources/javascript/bug_492_1.in#newcode66 testing/resources/javascript/bug_492_1.in:66: /QuadPoints [ 115.80264 718.9139232 157.211172 718.9139232 115.80264 706.264416 157.211172 ...
9 months ago (2016-08-26 21:21:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281273002/20001
9 months ago (2016-08-26 21:23:31 UTC) #8
commit-bot: I haz the power
9 months ago (2016-08-26 21:41:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0ee35908e906922a423fb18d7085ef80d0d8...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06