Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2281263002: AOT: Reassign class ids so class hierarchies have contiguous ranges. (Closed)

Created:
4 years, 3 months ago by rmacnak
Modified:
4 years, 3 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

AOT: Reassign class ids so class hierarchies have contiguous ranges. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/6a5a868a4ec3817bd894598f6055e8a2056ea8ea

Patch Set 1 #

Patch Set 2 : write protected code is on in flutter #

Patch Set 3 : write protected code is on in flutter #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -12 lines) Patch
M runtime/vm/class_table.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/class_table.cc View 1 3 chunks +19 lines, -3 lines 1 comment Download
M runtime/vm/heap.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +2 lines, -1 line 1 comment Download
M runtime/vm/precompiler.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 3 4 3 chunks +153 lines, -2 lines 0 comments Download
M runtime/vm/profiler.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M runtime/vm/raw_object.h View 6 chunks +13 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
rmacnak
4 years, 3 months ago (2016-08-26 21:14:27 UTC) #2
Florian Schneider
Lgtm https://codereview.chromium.org/2281263002/diff/60001/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/2281263002/diff/60001/runtime/vm/precompiler.cc#newcode2245 runtime/vm/precompiler.cc:2245: if (!cls.IsNull() && cls.IsObjectClass()) { cls.SuperClass() == I->object_store()->object_class() ...
4 years, 3 months ago (2016-08-26 22:14:34 UTC) #3
rmacnak
https://codereview.chromium.org/2281263002/diff/60001/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/2281263002/diff/60001/runtime/vm/precompiler.cc#newcode2245 runtime/vm/precompiler.cc:2245: if (!cls.IsNull() && cls.IsObjectClass()) { On 2016/08/26 22:14:34, Florian ...
4 years, 3 months ago (2016-08-26 23:12:32 UTC) #4
rmacnak
Committed patchset #5 (id:80001) manually as 6a5a868a4ec3817bd894598f6055e8a2056ea8ea (presubmit successful).
4 years, 3 months ago (2016-08-26 23:17:11 UTC) #6
siva
4 years, 3 months ago (2016-08-30 23:12:41 UTC) #8
Message was sent while issue was closed. 
DBC

https://codereview.chromium.org/2281263002/diff/80001/runtime/vm/class_table.cc
File runtime/vm/class_table.cc (right):

https://codereview.chromium.org/2281263002/diff/80001/runtime/vm/class_table....
runtime/vm/class_table.cc:217: RawClass** cls_by_old_cid = new
RawClass*[num_cids];
ASSERT(Thread::Current()->no_safepoint_scope_depth() > 0);

https://codereview.chromium.org/2281263002/diff/80001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2281263002/diff/80001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1899: // ASSERT(raw_class->ptr()->id_ == cid);
remap only happens in DART_PRECOMPILER, should this be

#if !defined(DART_PRECOMPILER)
  ASSERT(raw_class_ptr()->id_ == cid);
#endif

Powered by Google App Engine
This is Rietveld 408576698