Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/isolate.cc

Issue 2281263002: AOT: Reassign class ids so class hierarchies have contiguous ranges. (Closed)
Patch Set: review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/class_table.cc ('K') | « runtime/vm/heap.h ('k') | runtime/vm/precompiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 3c6c88b8049299086efe71ec19e2c6e858493fbd..c9cabbc387b01f87573f250e058cb1e2761c0d0e 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1895,7 +1895,8 @@ RawClass* Isolate::GetClassForHeapWalkAt(intptr_t cid) {
raw_class = class_table()->At(cid);
#endif // !PRODUCT
ASSERT(raw_class != NULL);
- ASSERT(raw_class->ptr()->id_ == cid);
+ // This is temporarily untrue during a class id remap.
+ // ASSERT(raw_class->ptr()->id_ == cid);
siva 2016/08/30 23:12:40 remap only happens in DART_PRECOMPILER, should thi
return raw_class;
}
« runtime/vm/class_table.cc ('K') | « runtime/vm/heap.h ('k') | runtime/vm/precompiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698