Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2281143002: Refactor external begin frame source into a base class (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by enne (OOO)
Modified:
1 year ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor external begin frame source into a base class There are several external begin frame sources in the code base, and they all have the same logic. mus will need another. So, refactor this logic into a base class that they all can reuse. The followup to this will be to make Android's CompositorImpl's ExternalBeginFrameSource derive from cc::ExternalBeginFrameSource. R=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/8b4aaaae53d89639fbebde0cfb8b7eeb73861fa5 Cr-Commit-Position: refs/heads/master@{#414927}

Patch Set 1 #

Patch Set 2 : Use client interfaces instead GOSH #

Total comments: 5

Patch Set 3 : danakj review #

Messages

Total messages: 16 (10 generated)
enne (OOO)
1 year ago (2016-08-26 18:55:09 UTC) #2
enne (OOO)
Maybe you'll like this version better.
1 year ago (2016-08-26 20:34:56 UTC) #6
danakj
LGTM https://codereview.chromium.org/2281143002/diff/20001/cc/scheduler/begin_frame_source.cc File cc/scheduler/begin_frame_source.cc (right): https://codereview.chromium.org/2281143002/diff/20001/cc/scheduler/begin_frame_source.cc#newcode187 cc/scheduler/begin_frame_source.cc:187: ExternalBeginFrameSource::~ExternalBeginFrameSource() {} = default https://codereview.chromium.org/2281143002/diff/20001/cc/scheduler/begin_frame_source.h File cc/scheduler/begin_frame_source.h (right): ...
1 year ago (2016-08-26 22:39:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281143002/40001
1 year ago (2016-08-27 00:11:08 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
1 year ago (2016-08-27 11:11:35 UTC) #14
commit-bot: I haz the power
1 year ago (2016-08-27 11:13:18 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b4aaaae53d89639fbebde0cfb8b7eeb73861fa5
Cr-Commit-Position: refs/heads/master@{#414927}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b