roll llvm-allocated-type 186332:204777.

roll llvm-allocated-type 186332:204777.

BUG=123758
NOTRY=true
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262898

[Dai Mikurube (NOT FULLTIME), 2014-04-08 07:27:28]

Hi Nico,

I'm resuming this customized Clang. Could you rubber-stamp it?
Binaries are not uploaded here since they're so large.

[Nico, 2014-04-08 16:02:53]

lgtm stamp

[Nico, 2014-04-08 16:04:10]

(I noticed that you're not including libstdc++4.7, which means if clang uses a
c++11 library feature that's not implemented in 4.6, it might not work
correctly. chromium clang binaries now bundle libstdc++, see e.g. the output of
`ldd  third_party/llvm-build/Release+Asserts/bin/clang`)

[Dai Mikurube (NOT FULLTIME), 2014-04-08 21:02:00]

On 2014/04/08 16:04:10, Nico wrote:
> (I noticed that you're not including libstdc++4.7, which means if clang uses a
> c++11 library feature that's not implemented in 4.6, it might not work
> correctly. chromium clang binaries now bundle libstdc++, see e.g. the output
of
> `ldd  third_party/llvm-build/Release+Asserts/bin/clang`)

Ah, yes, it doesn't contain libstdc++. IIRC, my build didn't contain it.
Do you have any switch or methods to build libstdc++?

[Nico, 2014-04-08 21:04:46]

See what CC=$HOME/gcc482prefix/bin/gcc
CXX=$HOME/thakis/gcc482prefix/bin/g++ tools/clang/scripts/update.sh
--gcc-toolchain $HOME/gcc482prefix does. It tells the llvm build ro set the
rpath to a custom libstdc++.
On Apr 8, 2014 2:02 PM, <dmikurube@chromium.org> wrote:

> On 2014/04/08 16:04:10, Nico wrote:
>
>> (I noticed that you're not including libstdc++4.7, which means if clang
>> uses a
>> c++11 library feature that's not implemented in 4.6, it might not work
>> correctly. chromium clang binaries now bundle libstdc++, see e.g. the
>> output
>>
> of
>
>> `ldd  third_party/llvm-build/Release+Asserts/bin/clang`)
>>
>
> Ah, yes, it doesn't contain libstdc++. IIRC, my build didn't contain it.
> Do you have any switch or methods to build libstdc++?
>
> https://codereview.chromium.org/228113004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dai Mikurube (NOT FULLTIME), 2014-04-08 21:16:09]

Sure, will check it today. Thanks!


On Wed, Apr 9, 2014 at 6:04 AM, Nico Weber <thakis@chromium.org> wrote:

> See what CC=$HOME/gcc482prefix/bin/gcc
> CXX=$HOME/thakis/gcc482prefix/bin/g++ tools/clang/scripts/update.sh
> --gcc-toolchain $HOME/gcc482prefix does. It tells the llvm build ro set the
> rpath to a custom libstdc++.
>  On Apr 8, 2014 2:02 PM, <dmikurube@chromium.org> wrote:
>
>> On 2014/04/08 16:04:10, Nico wrote:
>>
>>> (I noticed that you're not including libstdc++4.7, which means if clang
>>> uses a
>>> c++11 library feature that's not implemented in 4.6, it might not work
>>> correctly. chromium clang binaries now bundle libstdc++, see e.g. the
>>> output
>>>
>> of
>>
>>> `ldd  third_party/llvm-build/Release+Asserts/bin/clang`)
>>>
>>
>> Ah, yes, it doesn't contain libstdc++. IIRC, my build didn't contain it.
>> Do you have any switch or methods to build libstdc++?
>>
>> https://codereview.chromium.org/228113004/
>>
>


-- 
Dai MIKURUBE
   dmikurube@chromium.org

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dai Mikurube (NOT FULLTIME), 2014-04-10 02:11:33]

Committed patchset #2 manually as r262898 (presubmit successful).

[Dai Mikurube (NOT FULLTIME), 2014-04-10 02:12:27]

Committed with libstdc++. (Note that it's not uploaded here in Rietveld since
it's a large binary.)