Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2281123002: Add Gerrit API support to Skia's PRESUBMIT.py (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Gerrit API support to Skia's PRESUBMIT.py Also skip post upload hooks for Gerrit. BUG=skia:5674 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281123002 Committed: https://skia.googlesource.com/skia/+/b398ecc2a41684bd33138a920b446e987b2b30d0

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -21 lines) Patch
M PRESUBMIT.py View 1 2 4 chunks +71 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
rmistry
4 years, 3 months ago (2016-08-26 18:36:47 UTC) #4
jcgregorio
lgtm
4 years, 3 months ago (2016-08-29 11:36:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281123002/40001
4 years, 3 months ago (2016-08-29 15:12:35 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 15:13:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b398ecc2a41684bd33138a920b446e987b2b30d0

Powered by Google App Engine
This is Rietveld 408576698