Add Gerrit API support to Skia's PRESUBMIT.py

PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """Top-level presubmit script for Skia.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
@@ skipping 262 matching lines @@
         SKIA_TREE_STATUS_URL + '/current-sheriff')
     sheriff_details = input_api.json.loads(connection.read())
     if sheriff_details:
       tree_status_results[0]._message += (
           '\n\nPlease contact the current Skia sheriff (%s) if you are trying '
           'to submit a build fix\nand do not know how to submit because the '
           'tree is closed') % sheriff_details['username']
   return tree_status_results
 
 
+class CodeReview(object):
+  """Abstracts which codereview tool is used for the specified issue."""
+
+  def __init__(self, input_api):
+    self._issue = input_api.change.issue
+    self._gerrit = input_api.gerrit
+    self._rietveld_properties = None
+    if not self._gerrit:
+      self._rietveld_properties = input_api.rietveld.get_issue_properties(
+          issue=int(self._issue), messages=True)
+
+  def GetOwnerEmail(self):
+    if self._gerrit:
+      return self._gerrit.GetChangeOwner(self._issue)
+    else:
+      return self._rietveld_properties['owner_email']
+
+  def GetSubject(self):
+    if self._gerrit:
+      return self._gerrit.GetChangeInfo(self._issue)['subject']
+    else:
+      return self._rietveld_properties['subject']
+
+  def GetDescription(self):
+    if self._gerrit:
+      return self._gerrit.GetChangeDescription(self._issue)
+    else:
+      return self._rietveld_properties['description']
+
+  def IsDryRun(self):
+    if self._gerrit:
+      return self._gerrit.GetChangeInfo(
+          self._issue)['labels']['Commit-Queue'].get('value', 0) == 1
+    else:
+      return self._rietveld_properties['cq_dry_run']
+
+  def GetApprovers(self):
+    approvers = []
+    if self._gerrit:
+      for m in self._gerrit.GetChangeInfo(
+                   self._issue)['labels']['Code-Review']['all']:
+        if m.get("value") == 1:
+          approvers.append(m["email"])
+    else:
+      for m in self._rietveld_properties.get('messages', []):
+        if 'lgtm' in m['text'].lower():
+          approvers.append(m['sender'])
+    return approvers
+
+
 def _CheckOwnerIsInAuthorsFile(input_api, output_api):
   results = []
-  issue = input_api.change.issue
-  if issue and input_api.rietveld:
-    issue_properties = input_api.rietveld.get_issue_properties(
-        issue=int(issue), messages=False)
-    owner_email = issue_properties['owner_email']
+  if input_api.change.issue:
+    cr = CodeReview(input_api)
 
+    owner_email = cr.GetOwnerEmail()
     try:
       authors_content = ''
       for line in open(AUTHORS_FILE_NAME):
         if not line.startswith('#'):
           authors_content += line
       email_fnmatches = re.findall('<(.*)>', authors_content)
       for email_fnmatch in email_fnmatches:
         if fnmatch.fnmatch(owner_email, email_fnmatch):
           # Found a match, the user is in the AUTHORS file break out of the loop
           break
@@ skipping 27 matching lines @@
     # include dir, but not include/private.
     if (file_ext == '.h' and
         'include' == file_path.split(os.path.sep)[0] and
         'private' not in file_path):
       requires_owner_check = True
 
   if not requires_owner_check:
     return results
 
   lgtm_from_owner = False
-  issue = input_api.change.issue
-  if issue and input_api.rietveld:
-    issue_properties = input_api.rietveld.get_issue_properties(
-        issue=int(issue), messages=True)
-    if re.match(REVERT_CL_SUBJECT_PREFIX, issue_properties['subject'], re.I):
+  if input_api.change.issue:
+    cr = CodeReview(input_api)
+
+    if re.match(REVERT_CL_SUBJECT_PREFIX, cr.GetSubject(), re.I):
       # It is a revert CL, ignore the public api owners check.
       return results
 
-    if issue_properties['cq_dry_run']:
+    if cr.IsDryRun():
       # Ignore public api owners check for dry run CLs since they are not
       # going to be committed.
       return results
 
-    match = re.search(r'^TBR=(.*)$', issue_properties['description'], re.M)
+    match = re.search(r'^TBR=(.*)$', cr.GetDescription(), re.M)
     if match:
       tbr_entries = match.group(1).strip().split(',')
       for owner in PUBLIC_API_OWNERS:
         if owner in tbr_entries or owner.split('@')[0] in tbr_entries:
           # If an owner is specified in the TBR= line then ignore the public
           # api owners check.
           return results
 
-    if issue_properties['owner_email'] in PUBLIC_API_OWNERS:
+    if cr.GetOwnerEmail() in PUBLIC_API_OWNERS:
       # An owner created the CL that is an automatic LGTM.
       lgtm_from_owner = True
 
-    messages = issue_properties.get('messages')
-    if messages:
-      for message in messages:
-        if (message['sender'] in PUBLIC_API_OWNERS and
-            'lgtm' in message['text'].lower()):
-          # Found an lgtm in a message from an owner.
-          lgtm_from_owner = True
-          break
+    for approver in cr.GetApprovers():
+      if approver in PUBLIC_API_OWNERS:
+        # Found an lgtm in a message from an owner.
+        lgtm_from_owner = True
+        break
 
   if not lgtm_from_owner:
     results.append(
         output_api.PresubmitError(
             "If this CL adds to or changes Skia's public API, you need an LGTM "
             "from any of %s.  If this CL only removes from or doesn't change "
             "Skia's public API, please add a short note to the CL saying so "
             "and add one of those reviewers on a TBR= line.  If you don't know "
             "if this CL affects Skia's public API, treat it like it does."
             % str(PUBLIC_API_OWNERS)))
@@ skipping 10 matching lines @@
   * Adds 'NOTREECHECKS=true' for non master branch changes since they do not
     need to be gated on the master branch's tree.
   * Adds 'NOTRY=true' for non master branch changes since trybots do not yet
     work on them.
   * Adds 'NOPRESUBMIT=true' for non master branch changes since those don't
     run the presubmit checks.
   * Adds extra trybots for the paths defined in PATH_TO_EXTRA_TRYBOTS.
   """
 
   results = []
+  if cl.IsGerrit():
+    results.append(
+        output_api.PresubmitNotifyResult(
+            'Post upload hooks are not yet supported for Gerrit CLs'))
+    return results
+
   atleast_one_docs_change = False
   all_docs_changes = True
   for affected_file in change.AffectedFiles():
     affected_file_path = affected_file.LocalPath()
     file_path, _ = os.path.splitext(affected_file_path)
     if 'site' == file_path.split(os.path.sep)[0]:
       atleast_one_docs_change = True
     else:
       all_docs_changes = False
     if atleast_one_docs_change and not all_docs_changes:
@@ skipping 141 matching lines @@
     state and an error if it is in 'Closed' state.
   """
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   results.extend(
       _CheckTreeStatus(input_api, output_api, json_url=(
           SKIA_TREE_STATUS_URL + '/banner-status?format=json')))
   results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
   results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api))
   return results