cc: Fullscreen overlay removes all the other quads/planes.

cc: Fullscreen overlay removes all the other quads/planes.

OverlayStrategyFullscreen used to promote a quad to an overlay
finding a suitable quad, removing it from the quad_list and
pushing the overlay candidate to the list of overlay candidates.

This behavior was relying on ozone optimization that would
replace the primary plane if there were a fullscreen overlay
on top of it.

This CLs changes OverlayStrategyFullscreen behavior making it more
aggressive.
Once a quad that can be promoted is found, quad_list is erased since
all the quads are either not visible, or covered by the fullscreen
overlay, or the fullscreen overlay itself.

It also clear the overlay_list, that contains the primary buffer,
since the promoted overlay will be replacing it, in this way
we stop relying on the ozone optimization.

BUG=b/29430506
TEST=cc_unittests --gtest_filter="*FullscreenOverlayTest*", also tried it on minnie.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/4ed711acedc260e97ae3345cae1078df52c65f14
Cr-Commit-Position: refs/heads/master@{#414830}

[Daniele Castagna, 2016-08-26 20:36:43]

Description was changed from

==========
cc: Fullscreen overlay removes all the other quads/planes.

BUG=b/29430506
TEST=cc_unittests --gtest_filter="*FullscreenOverlayTest*", also tried it on
minnie.
==========

to

==========
cc: Fullscreen overlay removes all the other quads/planes.

BUG=b/29430506
TEST=cc_unittests --gtest_filter="*FullscreenOverlayTest*", also tried it on
minnie.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Daniele Castagna, 2016-08-26 20:53:17]

Description was changed from

==========
cc: Fullscreen overlay removes all the other quads/planes.

BUG=b/29430506
TEST=cc_unittests --gtest_filter="*FullscreenOverlayTest*", also tried it on
minnie.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Fullscreen overlay removes all the other quads/planes.

OverlayStrategyFullscreen used to promote a quad to an overlay
finding a suitable quad, removing it from the quad_list and
pushing the overlay candidate to the list of overlay candidates.

This behavior was relying on ozone optimization that would
replace the primary plane if there were a fullscreen overlay
on top of it.

This CLs changes OverlayStrategyFullscreen behavior making it more
aggressive.
Once a quad that can be promoted is found, quad_list is erased since
all the quads are either not visible, or covered by the fullscreen
overlay, or the fullscreen overlay itself.

It also clear the overlay_list, that contains the primary buffer,
since the promoted overlay will be replacing it, in this way
we stop relying on the ozone optimization.

BUG=b/29430506
TEST=cc_unittests --gtest_filter="*FullscreenOverlayTest*", also tried it on
minnie.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Daniele Castagna, 2016-08-26 20:53:30]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[Daniele Castagna, 2016-08-26 20:53:37]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:54:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 20:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:57:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Daniele Castagna, 2016-08-26 21:09:23]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 21:10:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2016-08-26 21:11:24]

lgtm

[commit-bot: I haz the power, 2016-08-26 22:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:15:36]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2016-08-26 22:15:38]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:16:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:21:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 22:23:13]

Description was changed from

==========
cc: Fullscreen overlay removes all the other quads/planes.

OverlayStrategyFullscreen used to promote a quad to an overlay
finding a suitable quad, removing it from the quad_list and
pushing the overlay candidate to the list of overlay candidates.

This behavior was relying on ozone optimization that would
replace the primary plane if there were a fullscreen overlay
on top of it.

This CLs changes OverlayStrategyFullscreen behavior making it more
aggressive.
Once a quad that can be promoted is found, quad_list is erased since
all the quads are either not visible, or covered by the fullscreen
overlay, or the fullscreen overlay itself.

It also clear the overlay_list, that contains the primary buffer,
since the promoted overlay will be replacing it, in this way
we stop relying on the ozone optimization.

BUG=b/29430506
TEST=cc_unittests --gtest_filter="*FullscreenOverlayTest*", also tried it on
minnie.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Fullscreen overlay removes all the other quads/planes.

OverlayStrategyFullscreen used to promote a quad to an overlay
finding a suitable quad, removing it from the quad_list and
pushing the overlay candidate to the list of overlay candidates.

This behavior was relying on ozone optimization that would
replace the primary plane if there were a fullscreen overlay
on top of it.

This CLs changes OverlayStrategyFullscreen behavior making it more
aggressive.
Once a quad that can be promoted is found, quad_list is erased since
all the quads are either not visible, or covered by the fullscreen
overlay, or the fullscreen overlay itself.

It also clear the overlay_list, that contains the primary buffer,
since the promoted overlay will be replacing it, in this way
we stop relying on the ozone optimization.

BUG=b/29430506
TEST=cc_unittests --gtest_filter="*FullscreenOverlayTest*", also tried it on
minnie.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/4ed711acedc260e97ae3345cae1078df52c65f14
Cr-Commit-Position: refs/heads/master@{#414830}
==========

[commit-bot: I haz the power, 2016-08-26 22:23:14]

Patchset 2 (id:??) landed as
https://crrev.com/4ed711acedc260e97ae3345cae1078df52c65f14
Cr-Commit-Position: refs/heads/master@{#414830}