Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: cc/output/overlay_unittest.cc

Issue 2281033003: cc: Fullscreen overlay removes all the other quads/planes. (Closed)
Patch Set: Rebase on master. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/overlay_strategy_fullscreen.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_unittest.cc
diff --git a/cc/output/overlay_unittest.cc b/cc/output/overlay_unittest.cc
index f0eb6a8b9c3058c7c2e9f2af443cfec5d68b2eff..f9264a9ad12b4dac31b07bdec697b78341c72d23 100644
--- a/cc/output/overlay_unittest.cc
+++ b/cc/output/overlay_unittest.cc
@@ -423,10 +423,12 @@ TEST_F(FullscreenOverlayTest, SuccessfulOverlay) {
ASSERT_EQ(1U, candidate_list.size());
RenderPass* main_pass = pass.get();
- // Check that the quad is gone.
- EXPECT_EQ(1U, main_pass->quad_list.size());
+ // Check that all the quads are gone.
+ EXPECT_EQ(0U, main_pass->quad_list.size());
+ // Check that we have only one overlay.
+ EXPECT_EQ(1U, candidate_list.size());
// Check that the right resource id got extracted.
- EXPECT_EQ(original_resource_id, candidate_list.back().resource_id);
+ EXPECT_EQ(original_resource_id, candidate_list.front().resource_id);
}
TEST_F(FullscreenOverlayTest, ResourceSizeInPixelsFail) {
« no previous file with comments | « cc/output/overlay_strategy_fullscreen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698